Repository navigation
fix(deps): update vulnerable transitive npm dependencies - #402
Merged
Merged
Conversation
Refresh lockfile entries to patched versions that the existing parent ranges already allow: - brace-expansion 2.0.2 -> 2.1.7, 5.0.4 -> 5.0.12 - form-data 4.0.5 -> 4.0.6 - http-proxy-middleware 3.0.5 -> 3.0.7 - express-rate-limit 8.3.1 -> 8.7.1, which moves ip-address 10.1.0 -> 10.7.4 - react-use 17.6.0 -> 17.6.1, which drops js-cookie 2.2.1 - js-yaml 4.3.1 -> 4.3.2 - mysql2 3.20.0 -> 3.24.6 - path-to-regexp 8.3.0 -> 8.4.2 - undici ^7 ranges 7.29.0 -> 7.30.1, ^8 range 8.7.0 -> 8.12.2 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 98285640-c517-4f08-a3d3-f17a64b93afb Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
@backstage/cli-module-build depends on @module-federation/enhanced ~2.8.2, which pulls in @module-federation/dts-plugin 2.8.2. That version pins adm-zip 0.6.0 and undici 7.29.0 exactly, and there is no newer 2.8.x release. Add resolutions scoped to those exact descriptors so they resolve to the patch releases adm-zip 0.6.1 and undici 7.29.1. Both versions are already in the lockfile through dts-plugin 2.9.2. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 98285640-c517-4f08-a3d3-f17a64b93afb Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF ScorecardScorecard details
Scanned Files
|
nithyatsu
approved these changes
Oct 23, 2026
DariuszPorowski
pushed a commit
that referenced
this pull request
Oct 26, 2026
(cherry picked from commit 9d295b5) Signed-off-by: Dariusz Porowski <3431813+DariuszPorowski@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves transitive dependencies with high severity advisories to patched versions. Most of it is a
yarn.lockrefresh within ranges the parents already allow. Two exact pins from@module-federation/dts-plugin@2.8.2need narrowresolutionsentries.Reason for change
These advisories were open on
adm-zip,brace-expansion,form-data,http-proxy-middleware,ip-address,js-cookie,js-yaml,mysql2,path-to-regexp, andundici. Dependabot security update runs for this repo have been failing, so these need a manual update.Lockfile only, within existing ranges (first commit):
brace-expansionform-datahttp-proxy-middleware@types/http-proxy-middleware(range*). Kept on 3.x instead of jumping to 4.xip-addressexpress-rate-limit8.3.1 pinned 10.1.0. Refreshed it to 8.7.1 (within^8.2.2), which uses^10.2.0js-cookiereact-use17.6.0 usedjs-cookie@^2. Allreact-use@^17ranges now resolve to 17.6.1, which uses 3.0.8js-yamlmysql2^3resolutionpath-to-regexpundici^7and^8rangesResolutions (second commit):
@backstage/cli-module-builddepends on@module-federation/enhanced@~2.8.2, which pulls in@module-federation/dts-plugin@2.8.2. That version pinsadm-zip@0.6.0andundici@7.29.0exactly, and there is no newer 2.8.x. The resolutions are keyed to those exact descriptors and move them to the patch releasesadm-zip@0.6.1andundici@7.29.1, which are already in the lockfile throughdts-plugin@2.9.2.Not fixed here:
basic-ftp5.3.1 (viapac-proxy-agent>get-uri): the fix is only in 6.2.1, and even the latestget-uristill depends onbasic-ftp@^5.@graphql-tools/utils8.x (via@backstage/backend-openapi-utils>mockttp@3): the fix is only in 12.0.1.mockttp@4still uses^11.node-forge1.4.0: no patched version is available yet.How to test
yarn install --immutable. It should pass with no lockfile changes.yarn why <pkg>for each package above. Only the "After" versions should show up, plus the unaffected major lines noted.yarn tsc,yarn lint:all,yarn build:all, andyarn test:all. All should pass.File change summary
yarn.lockadm-zip@0.6.0,undici@7.29.0,js-cookie@2.2.1,react-use@17.6.0, and@types/js-cookie. Picked up new transitive deps ofmysql23.24.6 (sql-escaper,iconv-lite).package.jsonresolutionsforadm-zip@npm:0.6.0andundici@npm:7.29.0.