add a proc mechanism to Blacklight::Configuration#property to allow deferred resolution of some default values#2720
Closed
add a proc mechanism to Blacklight::Configuration#property to allow deferred resolution of some default values#2720
Conversation
Contributor
barmintor
commented
May 12, 2022
barmintor
commented
- if property default values are not defined under lib, they may not be available until application is loaded, causing issues for downstream apps running generators
- fixes Blacklight::DocumentFactory class is not loaded when Blacklight::Configuration property definitions are set #2705
…eferred resolution of some default values - if property default values are not defined under lib, they may not be available until application is loaded, causing issues for downstream apps running generators - fixes #2705
Contributor
Author
|
I'm not enamored of this mechanism, but... it works. Without something like this, I was left using |
Contributor
Author
|
Converting this to a draft as there may just need to be zeitwerk changes implemented in the plugins, see projectblacklight/blacklight_range_limit#185 |
Contributor
Author
|
Closed as was #2705 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.