Defer resolving Blacklight::Configuration default properties so we can use auto-loaded classes #2826
Merged
Defer resolving Blacklight::Configuration default properties so we can use auto-loaded classes #2826
Conversation
cbeer
force-pushed
the
2705-prop-default-proc
branch
from
e46c1b4 to
d2fb198
Compare
cbeer
force-pushed
the
2705-prop-default-proc
branch
2 times, most recently
from
fbfb783 to
ed08ba5
Compare
cbeer
changed the title
cbeer
force-pushed
the
2705-prop-default-proc
branch
from
ed08ba5 to
f71ce7f
Compare
jcoyne
approved these changes
Oct 6, 2022
cbeer
added a commit
that referenced
this pull request
Feb 3, 2023
Merged
cbeer
added a commit
that referenced
this pull request
Feb 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if property default values are not defined under lib, they may not be available until application is loaded, causing issues for downstream apps running generators.
This shouldn't be necessary, but it's difficult for plugins (and e.g. arclight which uses blacklight + some plugins) to convince zeitwerk to get the load order right.
Fixes #2705
(also see discussion from #2720)