[Fix] Update wildcard subscription to exclude atomic write attributes and CGEN_2_2 test#72742
Open
j-ororke wants to merge 3 commits into
Open
Conversation
… and CGEN_2_2 test - Adds parsing for atomicWrite / atomic-write attributes in spec_parsing - Processes that metadata during setup so atomic-write attributes are excluded from wildcard subscription verification - Adds the full per-test-class opt-out with disable_wildcard_subscription = True for CGEN_2_2 test module
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request disables framework wildcard subscription in TC_CGEN_2_2.py and adds support for parsing the atomic_write attribute quality from XML specifications. The feedback suggests updating _is_atomic_write_attribute to check for both atomicWrite and atomic-write attributes to ensure full compatibility with different XML formats.
for more information, see https://pre-commit.ci
|
PR #72742: Size comparison from 413ff63 to 6869f9d Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72742 +/- ##
=======================================
Coverage 56.79% 56.79%
=======================================
Files 1642 1642
Lines 112757 112757
Branches 13139 13139
=======================================
Hits 64040 64040
Misses 48717 48717 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
PR #72742: Size comparison from 413ff63 to dfb13da Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetActivePresetdoes not trigger a subscription report forActivePresetHandleattribute #43582: Thermostat ActivePresetHandle attribute does not emit attribute reports on changes. Which is now surfaced in this PR.Related issues
Resolves: #72732
Testing
CGEN_2_2: