Repository navigation
refactor(i18n): show the code view, logs, updates, Teleport, and Go To in Fluent - #910
Merged
Merged
Conversation
…o in Fluent Phase 2 of docs/i18n.md for the smaller views: the code view and editor, the log window, the theme picker, App Updates and its release notes, Teleport's dialog, and the palette's Go To and project rows. Each module is marked `// i18n: migrated` and keeps its English in its own .ftl file (code-view, editor, log-window, theme-picker, update-panel, teleport, palette-go-to, palette-projects), so parallel migrations do not share a catalog. - Hand-built plurals become Fluent selectors: Teleport's unpushed commits, changed files and warnings, and the theme count. - Teleport's step names and pane descriptions are chosen by variant in the app (teleport/text.rs); herdr-remote keeps its English for logs and errors. Its test-support exports gain the review types the leak test builds. - Go To badges, status words, preview facts and the agent filter are messages; search still matches the English status words, and the filter chips' test selectors are stable names rather than their labels. - release_notes' inline tests move to release_notes/tests.rs, and palette/projects' to palette/projects/tests.rs, so the modules can be marked migrated. - Each surface has an en-XA leak test: the log window, the theme picker, a code tab, every App Updates state, every Teleport stage, and Go To. $error and the updater's $reason placeables keep their English Display.
Owner
Author
|
|
 [Medium impact] The PR appears safe to merge; no actionable defects were found. SummaryMoves code tabs, logs, the theme picker, App Updates, Teleport, and palette navigation/project text into Fluent.
Reviews (2) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
App Updates showed the updater's own install steps, such as "Starting Homebrew...", in English. The updater now reports them as a typed `Progress`, with the lines Homebrew or a system package prints kept as data, and the panel words each step from update-panel.ftl. The Linux helper prints its steps over a pipe, so its one step is parsed back at that boundary. The command line keeps the English wording. The App Updates leak test now covers every install step, and the code tab's leak test treats any piece of its truncated path as data: on Windows the header cut the temp path down to its drive letter.
✅ Deploy Preview for herdr-ui canceled.
|
# Conflicts: # crates/herdr-gpui/src/theme_picker.rs # docs/i18n.md
Owner
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of Phase 2 of
docs/i18n.md(string migration), following #880's patterns. This PR covers the smaller views in my scope. The browser and chats follow in their own PRs. English text is unchanged except for one plural noted below.Each module is marked
// i18n: migratedand has its own.ftlfile, so the parallel migrations don't share a catalog:code_viewcode-view.ftleditoreditor.ftllog_windowlog-window.ftltheme_pickertheme-picker.ftlupdate_panel,release_notes;herdr-updaterreports install steps as a typedProgressupdate-panel.ftlteleportteleport.ftlpalettepalette-go-to.ftlpalettepalette-projects.ftlPlurals. Teleport's "commit(s)", "file(s)" and "warning(s)" and the theme picker's count are now Fluent selectors. The only visible English change: "1 of 1 themes" now reads "1 of 1 theme".
Teleport. Step names and pane descriptions ("claude: resume session", "Run cargo test") were English strings from
herdr-remote. The app now picks the message by variant inteleport/text.rs, andherdr-remotekeeps its English for logs and#[error]. Each review destination is one whole sentence per variant instead of a sentence built from fragments.herdr-remote'stest-supportexports gainNode,SourceStateandTabPlanso the leak test can build a review. Production API is unchanged.Palette. Go To's badges and status words are messages. Search still matches the English status words and "agent" as well as the translated ones. The agent filter chips' test selectors now use stable names instead of their labels.
Data, not messages. The editor's shell scripts and Neovim command (
// i18n: data), names, paths, versions, the release notes themselves, and Teleport's warnings.Moved tests.
release_notes.rsandpalette/projects.rskept their tests inline. Those tests move torelease_notes/tests.rs(withstructure.rsundertests/) andpalette/projects/tests.rs, so the modules can be marked migrated. The test bodies are unchanged.Left as is.
$errorplaceables and the updater's$reasonkeep their EnglishDisplay; another agent is localizing errors. The relative age inside "Last seen { $age }" still comes fromherdr-vcs'scheckpoint::age, which is the separate relative-times item in "What is left".The second commit reports the updater's own install steps ("Starting Homebrew..." and so on) as
herdr_updater::Progressvariants the panel translates; what Homebrew or a system package prints stays data, and the command line keeps English. It also fixes the code tab's leak test on Windows, where the header truncated the temp path down to its drive letter.docs/i18n.md's "What is left" and its list of leak tests are updated.Validation
just formatjust cion1e942e98c(macOS arm64, after mergingmain): passed. 15200 Rust tests, 0 failed.just lint-linuxandjust lint-windows: clean (the updater's Homebrew and Linux install code iscfg-gated).Screenshots
No native screenshots: none were captured in this session, and no desktop interaction was done. Apart from the singular theme count, English rendering should be unchanged.