User/yliu/new sim launch#293
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s) addressed: #171.
Not directly mentioned in it, but helps with refactoring sim launch because you don't have to run download model step in sim.launch.py
Description:
Instead of running the gz model download step in sim.launch, it's better to just track all gz resources that we are using in monorepo.
It might have been easier to just track the files directly in to monorepo, so just directly copying the files, then adding whatever we need. It could also be better because its less submodule bloat.
I don't have a strong opinion on this, but here are some things to keep in mind:
The submodule I added is a fork of px4's px4-gazebo-models repo, and that main branch is what they use for the simulation-gazebo model downloads. If we want to pull in any changes from upstream/main, then having a submodule would be easier, but I honestly don't really see a big reason to be updating frequently.
And if we want to modify, we need to PR in the submodule, merge into submodule main, then update monorepo pinned tag on the submodule, then remind ppl to run git submodule update --init --recursive