Skip to content

SVG icons in buttons should be decorative #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
riasvdv wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SVG icons in buttons should be decorative #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/toolbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,15 @@ export class Toolbar {
.replace(/\son\w+\s*=\s*["'][^"']*["']/gi, '')
.replace(/\son\w+\s*=\s*[^\s>]*/gi, '');

return cleaned;
const template = document.createElement('template');
template.innerHTML = cleaned;

template.content.querySelectorAll('svg').forEach(icon => {
icon.setAttribute('aria-hidden', 'true');
icon.setAttribute('focusable', 'false');
});

return template.innerHTML;
}

/**
Expand Down
7 changes: 7 additions & 0 deletions test/toolbar.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,13 @@ console.log('━'.repeat(50));
'Toolbar item semantics',
'Expected toggle state only on toggle buttons and separators outside tab order'
);
assert(
Array.from(toolbar.querySelectorAll('.overtype-toolbar-button svg')).every(icon =>
icon.getAttribute('aria-hidden') === 'true' && icon.getAttribute('focusable') === 'false'
),
'Toolbar icons are decorative',
'Expected every toolbar SVG icon to be hidden from assistive technology and removed from SVG focus'
);

editor.destroy();
})();
Expand Down