SVG icons in buttons should be decorative#118
Open
riasvdv wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small accessibility improvement, SVG icons within the toolbar buttons should be hidden from assistive technologies.
Summary by cubic
Marks SVG icons in toolbar buttons as decorative by setting aria-hidden="true" and focusable="false" during sanitization, so screen readers ignore them and they aren’t focusable. Adds a test to enforce these attributes on all toolbar button SVGs.
Written for commit dd8a9c6. Summary will update on new commits.