Skip to content

Fix social link form resubmission after removing invalid link #6945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvanhorn wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix social link form resubmission after removing invalid link #6945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72fb40b
fix: remove required attribute when hiding social link row
mvanhorn Mar 27, 2026
8e8f42c
fix: also strip required attr in :checked.each on page load
Mar 29, 2026
d474aeb
refactor: chain jQuery calls in checked.each loop
Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/assets/javascripts/user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ $(function () {
if (destroyCheckbox) {
destroyCheckbox.checked = true;
row.addClass("d-none");
row.find("input[type='text']").removeAttr("required");
Comment thread
hlfan marked this conversation as resolved.
} else {
row.remove();
}
Expand All @@ -29,7 +30,7 @@ $(function () {
});

$(".social_link_destroy input[type='checkbox']:checked").each(function () {
$(this).closest(".row").addClass("d-none");
$(this).closest(".row").addClass("d-none").find("input[type='text']").removeAttr("required");
});

renumberSocialLinks();
Expand Down
26 changes: 26 additions & 0 deletions test/system/profile_links_change_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,4 +168,30 @@ class ProfileLinksChangeTest < ApplicationSystemTestCase
assert_link "example.com/d"
end
end

test "can remove invalid link after validation error and resubmit" do
user = create(:user)

sign_in_as(user)
visit user_path(user)

within_content_body do
click_on "Edit Profile Details"
click_on "Edit Links"
click_on "Add Social Link"
fill_in "Social Profile Link 1", :with => "https://example.com/valid"
click_on "Add Social Link"
click_on "Update Profile"

assert_field "Social Profile Link 2"

click_on "Remove Social Profile Link 2"

assert_no_field "Social Profile Link 2"

click_on "Update Profile"

assert_link "example.com/valid"
end
end
end