Fix social link form resubmission after removing invalid link#6945
Open
mvanhorn wants to merge 3 commits intoopenstreetmap:masterfrom
Open
Fix social link form resubmission after removing invalid link#6945mvanhorn wants to merge 3 commits intoopenstreetmap:masterfrom
mvanhorn wants to merge 3 commits intoopenstreetmap:masterfrom
Conversation
When a social link with validation errors is removed via the "Remove" button, the row is hidden with d-none but the input retains its required attribute. This prevents form submission because HTML5 validation rejects hidden required fields that cannot be focused. Strip the required attribute from the text input when marking a social link for destruction so the form can be resubmitted. Closes openstreetmap#6903 Co-Authored-By: Claude Opus 4.6 <[email protected]>
hlfan
reviewed
Mar 28, 2026
Collaborator
|
Please see #6937 (comment) and the guideline for pull requests. |
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Contributor
Author
tomhughes
added
the
ai-assisted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6903.
When a social link row is removed after a validation error, the row is hidden (
d-none) and the_destroycheckbox is checked, but the text input keeps itsrequiredattribute. HTML5 validation then blocks form submission because it cannot focus the hidden required field.This adds a single line to strip the
requiredattribute from the text input when marking a social link for destruction.Reproduction
Test plan