OCPNODE-4450: Remove UserNamespacesSupport feature gate label from test#31071
OCPNODE-4450: Remove UserNamespacesSupport feature gate label from test#31071BhargaviGudi wants to merge 1 commit intoopenshift:mainfrom
Conversation
The UserNamespacesSupport feature gate was removed from openshift/api in openshift/api#2762 because it has been enabled by default since Kubernetes 1.33 and is no longer needed. Remove the obsolete feature gate label from the user namespace test to reflect that this is now a GA feature. Related: openshift/api#2762
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
@BhargaviGudi: This pull request references Jira Issue OCPBUGS-74525, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughA feature-gate label Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 11 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@BhargaviGudi: This pull request references OCPNODE-4450 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BhargaviGudi, coderabbitai[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Scheduling required tests: |
|
I don't think it's required. https://redhat.atlassian.net/browse/OCPBUGS-74525
It's removed from downstream, but still exists in upstream. |
|
/hold |
|
Closing PR since:
|
|
@BhargaviGudi: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does
Removes the obsolete
[FeatureGate:UserNamespacesSupport]label from the user namespace test suite.Why we need it
The UserNamespacesSupport feature gate was removed from openshift/api in openshift/api#2762 because:
This PR updates the test label to reflect that user namespaces are now a GA feature.
Testing
The e2e-gcp-ovn-usernamespace CI job will validate that the test still runs successfully.
Related
Summary by CodeRabbit