Skip to content

OCPNODE-4450: Remove UserNamespacesSupport feature gate label from test#31071

Closed
BhargaviGudi wants to merge 1 commit intoopenshift:mainfrom
BhargaviGudi:OCPBUGS-74525-remove-usernamespace-label
Closed

OCPNODE-4450: Remove UserNamespacesSupport feature gate label from test#31071
BhargaviGudi wants to merge 1 commit intoopenshift:mainfrom
BhargaviGudi:OCPBUGS-74525-remove-usernamespace-label

Conversation

@BhargaviGudi
Copy link
Copy Markdown
Contributor

@BhargaviGudi BhargaviGudi commented Apr 27, 2026

What this PR does

Removes the obsolete [FeatureGate:UserNamespacesSupport] label from the user namespace test suite.

Why we need it

The UserNamespacesSupport feature gate was removed from openshift/api in openshift/api#2762 because:

  • The feature has been enabled by default since Kubernetes 1.33
  • The feature gate is no longer needed

This PR updates the test label to reflect that user namespaces are now a GA feature.

Testing

The e2e-gcp-ovn-usernamespace CI job will validate that the test still runs successfully.

/test e2e-gcp-ovn-usernamespace

Related

Summary by CodeRabbit

  • Tests
    • Updated a test suite configuration by removing a feature-gate label reference, while preserving other suite identifiers.

The UserNamespacesSupport feature gate was removed from openshift/api
in openshift/api#2762 because it has been
enabled by default since Kubernetes 1.33 and is no longer needed.

Remove the obsolete feature gate label from the user namespace test
to reflect that this is now a GA feature.

Related: openshift/api#2762
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 27, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@BhargaviGudi: This pull request references Jira Issue OCPBUGS-74525, which is invalid:

  • expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.22.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does

Removes the obsolete [FeatureGate:UserNamespacesSupport] label from the user namespace test suite.

Why we need it

The UserNamespacesSupport feature gate was removed from openshift/api in openshift/api#2762 because:

  • The feature has been enabled by default since Kubernetes 1.33
  • The feature gate is no longer needed

This PR updates the test label to reflect that user namespaces are now a GA feature.

Testing

The e2e-gcp-ovn-usernamespace CI job will validate that the test still runs successfully.

/test e2e-gcp-ovn-usernamespace

Related

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

Walkthrough

A feature-gate label [FeatureGate:UserNamespacesSupport] was removed from the Ginkgo suite description string in a test file while retaining other suite identifiers.

Changes

Cohort / File(s) Summary
Test Suite Metadata
test/extended/node/nested_container.go
Removed [FeatureGate:UserNamespacesSupport] label from nested container suite description; retained [Suite:openshift/usernamespace], [sig-node], and [FeatureGate:ProcMountType] identifiers.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Test Structure And Quality ⚠️ Warning Test lacks proper setup/cleanup blocks for cluster resources and has inconsistent assertion error messages without meaningful descriptions. Add BeforeEach/AfterEach blocks with DeferCleanup for resource cleanup and include error messages in all Expect() assertions.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The test suite properly maintains stable and deterministic test names with only static, descriptive language and no dynamic information that could change between runs.
Microshift Test Compatibility ✅ Passed This PR only removes a feature gate label from an existing test, not adding new tests. The custom check applies only to newly added Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR removes obsolete feature gate label from test; does not introduce new test logic or multi-node assumptions affecting SNO compatibility.
Topology-Aware Scheduling Compatibility ✅ Passed This PR only modifies a test file's Ginkgo suite description by removing a feature gate label. The custom check scope is limited to deployment manifests, operator code, or controllers. Since this change affects none of those categories and introduces no scheduling constraints, the check is not applicable.
Ote Binary Stdout Contract ✅ Passed PR modifies only the Ginkgo test suite description string, removing the [FeatureGate:UserNamespacesSupport] label without introducing stdout writes or violating the OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR removes a feature gate label from an existing test's suite description, not adding new Ginkgo e2e tests. The custom check applies only to newly added tests.
Title check ✅ Passed The title clearly and specifically describes the main change: removing the UserNamespacesSupport feature gate label from a test, which aligns with the changeset that removes this label from the nested_container.go test suite.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from PannagaRao and kannon92 April 27, 2026 06:41
@BhargaviGudi BhargaviGudi changed the title OCPBUGS-74525: Remove UserNamespacesSupport feature gate label from test OCPNODE-4450: Remove UserNamespacesSupport feature gate label from test Apr 27, 2026
@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 27, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 27, 2026

@BhargaviGudi: This pull request references OCPNODE-4450 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

What this PR does

Removes the obsolete [FeatureGate:UserNamespacesSupport] label from the user namespace test suite.

Why we need it

The UserNamespacesSupport feature gate was removed from openshift/api in openshift/api#2762 because:

  • The feature has been enabled by default since Kubernetes 1.33
  • The feature gate is no longer needed

This PR updates the test label to reflect that user namespaces are now a GA feature.

Testing

The e2e-gcp-ovn-usernamespace CI job will validate that the test still runs successfully.

/test e2e-gcp-ovn-usernamespace

Related

Summary by CodeRabbit

  • Tests
  • Updated a test suite configuration by removing a feature-gate label reference, while preserving other suite identifiers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Apr 27, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BhargaviGudi, coderabbitai[bot]
Once this PR has been reviewed and has the lgtm label, please assign rphillips for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@bitoku
Copy link
Copy Markdown
Contributor

bitoku commented Apr 27, 2026

I don't think it's required.

https://redhat.atlassian.net/browse/OCPBUGS-74525

Any tests containing the feature gate name that report into component readiness should NOT be renamed.

It's removed from downstream, but still exists in upstream.

@bitoku
Copy link
Copy Markdown
Contributor

bitoku commented Apr 27, 2026

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2026
@BhargaviGudi
Copy link
Copy Markdown
Contributor Author

Closing PR since:

  • The feature gate still exists in upstream Kubernetes
  • The test label is used for component readiness tracking
    This change is not needed. Closing this PR.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 27, 2026

@BhargaviGudi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 95c5c27 link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants