TRT-2644: Run CP tests everywhere

[rexagod]

These were restricted to TP only.

Summary by CodeRabbit

• Tests
  • Simplified test initialization by removing conditional skip logic. Test suite now executes consistently across all supported cluster configurations without version-specific eligibility checks.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@rexagod: This pull request references TRT-2644 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

These were restricted to TP only, in addition to having a feature-gate tag on them, which was lifted a while ago.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a252a042-a1a2-481e-9298-3a75ec8690cc

📥 Commits

Reviewing files that changed from the base of the PR and between 1da8150 and 8acd71c.

📒 Files selected for processing (1)

• test/extended/prometheus/collection_profiles.go

💤 Files with no reviewable changes (1)

• test/extended/prometheus/collection_profiles.go

---

Walkthrough

The test suite's BeforeAll setup was simplified by removing a TechPreviewNoUpgrade eligibility check and the conditional skip for unsupported clusters, allowing test execution to always proceed with client initialization.

Changes

Cohort / File(s)	Summary
Test Setup Simplification test/extended/prometheus/collection_profiles.go	Removed TechPreviewNoUpgrade eligibility validation and skip logic; test now unconditionally initializes Kubernetes and Prometheus clients and waits for ConfigMap.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 10 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Test Structure And Quality	⚠️ Warning	The test file fails requirement #4 (Assertion messages). Eight Expect assertions lack meaningful failure messages that would help diagnose test failures.	Add descriptive failure messages to all Expect assertions by providing a second parameter string to improve test debuggability.
Microshift Test Compatibility	⚠️ Warning	Test uses PrometheusOperator monitoring APIs unavailable on MicroShift without protective mechanisms like [Skipped:MicroShift] or IsMicroShiftCluster() checks.	Add [apigroup:monitoring.coreos.com] tag, [Skipped:MicroShift] label, or IsMicroShiftCluster() guard in BeforeAll hook to skip test on MicroShift.

✅ Passed checks (10 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'TRT-2644: Run CP tests everywhere' directly summarizes the main change: removing TP-only restrictions to allow collection profile tests to run on all cluster types.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Test file contains only static, deterministic test names with no dynamic values or string concatenation.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Test does not make multi-node cluster assumptions; all operations (ConfigMap management, Prometheus queries, ServiceMonitor validation) work identically on SNO.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only test code in collection_profiles.go by removing skip conditions. No deployment manifests, operator code, or controllers are modified, and no scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	The PR removes 3 lines containing a TechPreviewNoUpgrade check and g.Skip() calls. No new code is added (+0 lines), so no new stdout writes can be introduced. Removing a skip condition does not violate the OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This pull request adds new Ginkgo e2e tests with no IPv4 hardcoded addresses, IPv4-specific parsing logic, or external connectivity requirements. All networking is internal to the cluster and properly handles both IPv4 and IPv6.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Review rate limit: 9/10 reviews remaining, refill in 6 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[simonpasquier]

/approve
/lgtm

[rexagod]

/hold

@simonpasquier Wouldn't dropping the feature-gate tag end up renaming these tests, and disrupt historical records for component readiness? Found a PR that decided against doing so: #31071 (comment).

[rexagod]

I'll drop the test name change, @claude had a false positive on this, it seems:

The README doesn't say "remove the tag once the feature is in Default." That was my inference based on the fact that:
  1. The feature is now enabled in all feature sets (including Default)
  2. The test was skipping on non-TechPreview clusters via IsTechPreviewNoUpgrade
  3. That skip would prevent the tests from running on clusters where the feature is actually active

[openshift-trt]

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 1da8150

Job Name	New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial	High - "[sig-instrumentation][Serial] The collection profiles feature-set in a heterogeneous environment, should expose information about the applied collection profile using meta-metrics [Suite:openshift/conformance/serial]" is a new test, was only seen in one job, and failed 1 time(s) against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial	High - "[sig-instrumentation][Serial] The collection profiles feature-set in a heterogeneous environment, should have at least one implementation for each collection profile [Suite:openshift/conformance/serial]" is a new test, was only seen in one job, and failed 1 time(s) against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial	High - "[sig-instrumentation][Serial] The collection profiles feature-set in a heterogeneous environment, should revert to default collection profile when an empty collection profile value is specified [Suite:openshift/conformance/serial]" is a new test, was only seen in one job, and failed 1 time(s) against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial	High - "[sig-instrumentation][Serial] The collection profiles feature-set in a homogeneous minimal environment, should hide default metrics [Suite:openshift/conformance/serial]" is a new test, was only seen in one job, and failed 1 time(s) against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial	High - "[sig-instrumentation][Serial] The collection profiles feature-set initially, in a homogeneous default environment, should expose default metrics [Suite:openshift/conformance/serial]" is a new test, was only seen in one job, and failed 1 time(s) against the current commit.

New tests seen in this PR at sha: 1da8150

• "[sig-instrumentation][Serial] The collection profiles feature-set in a heterogeneous environment, should expose information about the applied collection profile using meta-metrics [Suite:openshift/conformance/serial]" [Total: 1, Pass: 0, Fail: 1, Flake: 0]
• "[sig-instrumentation][Serial] The collection profiles feature-set in a heterogeneous environment, should have at least one implementation for each collection profile [Suite:openshift/conformance/serial]" [Total: 1, Pass: 0, Fail: 1, Flake: 0]
• "[sig-instrumentation][Serial] The collection profiles feature-set in a heterogeneous environment, should revert to default collection profile when an empty collection profile value is specified [Suite:openshift/conformance/serial]" [Total: 1, Pass: 0, Fail: 1, Flake: 0]
• "[sig-instrumentation][Serial] The collection profiles feature-set in a homogeneous minimal environment, should hide default metrics [Suite:openshift/conformance/serial]" [Total: 1, Pass: 0, Fail: 1, Flake: 0]
• "[sig-instrumentation][Serial] The collection profiles feature-set initially, in a homogeneous default environment, should expose default metrics [Suite:openshift/conformance/serial]" [Total: 1, Pass: 0, Fail: 1, Flake: 0]

[simonpasquier]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coderabbitai[bot], rexagod, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/extended/prometheus/OWNERS [rexagod,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[rexagod]

/unhold
/retest-required

[rexagod]

/retest-required

[rexagod]

/test e2e-gcp-ovn-upgrade

[openshift-trt]

Job Failure Risk Analysis for sha: 8acd71c

Job Name	Failure Risk
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade	High [Monitor:legacy-test-framework-invariants-pathological][sig-arch] events should not repeat pathologically for ns/openshift-multus This test has passed 99.61% of 5348 runs on release 5.0 [Overall] in the last week.

[rexagod]

/test e2e-gcp-ovn-upgrade

Failures are unrelated, but I see the job passing a few times in the job history. Retesting.

[simonpasquier]

/verified by @simonpasquier

[openshift-ci-robot]

@simonpasquier: This PR has been marked as verified by @simonpasquier.

Details

In response to this:

/verified by @simonpasquier

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 453173e and 2 for PR HEAD 8acd71c in total

[openshift-ci]

@rexagod: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.