Skip to content

fix(core): Skip circuit breaker for DLQ pipeline buffer #7185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graytaylor0 merged 1 commit into from
Oct 8, 2026
+22 −0
Merged

fix(core): Skip circuit breaker for DLQ pipeline buffer #7185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...repper-core/src/main/java/org/opensearch/dataprepper/core/parser/PipelineTransformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,9 @@ private Buffer applyCircuitBreakerToBuffer(final Source source, final Buffer buf
if (source instanceof PipelineConnector)
return buffer;

if (source instanceof HeadlessPipelineSource)
return buffer;

if (buffer.isWrittenOffHeapOnly())
return buffer;

Expand Down
19 changes: 19 additions & 0 deletions ...r-core/src/test/java/org/opensearch/dataprepper/core/parser/PipelineTransformerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,25 @@ void testMultipleSinksWithFailurePipeline() {
assertThat(((HeadlessPipelineSource)failurePipeline.getSource()).getAcknowledgementsEnabled(), equalTo(false));
}

@Test
void parseConfiguration_does_not_apply_circuit_breaker_to_failure_pipeline_buffer() {
final CircuitBreaker circuitBreaker = mock(CircuitBreaker.class);
when(circuitBreakerManager.getGlobalCircuitBreaker())
.thenReturn(Optional.of(circuitBreaker));
when(dataPrepperConfiguration.getFailurePipelineName()).thenReturn(DataPrepperConfiguration.DEFAULT_FAILURE_PIPELINE_NAME);
when(expressionEvaluator.isValidExpressionStatement("/value == raw")).thenReturn(true);
when(expressionEvaluator.isValidExpressionStatement("/value == service")).thenReturn(true);
mockDataPrepperConfigurationAccesses();
final PipelineTransformer pipelineTransformer =
createObjectUnderTest(TestDataProvider.VALID_MULTIPLE_SINKS_WITH_FAILURE_PIPELINE_CONFIG_FILE);
final Map<String, Pipeline> pipelineMap = pipelineTransformer.transformConfiguration(this.pipelinesDataFlowModel);

final Pipeline failurePipeline = pipelineMap.get(DataPrepperConfiguration.DEFAULT_FAILURE_PIPELINE_NAME);
assertThat(failurePipeline, notNullValue());
assertThat(failurePipeline.getSource(), instanceOf(HeadlessPipelineSource.class));
assertThat(failurePipeline.getBuffer(), CoreMatchers.not(instanceOf(CircuitBreakingBuffer.class)));
}

@Test
void testMultipleProcessors() {
mockDataPrepperConfigurationAccesses();
Expand Down
Loading