Repository navigation
fix(core): Skip circuit breaker for DLQ pipeline buffer - #7185
Merged
Merged
Conversation
The DLQ (failure) pipeline uses a HeadlessPipelineSource which writes events to its buffer via sendEvents(). When a circuit breaker is active, the buffer is wrapped with CircuitBreakingBuffer which throws TimeoutException when the breaker is open. This causes DLQ writes to block indefinitely (with acks enabled) or release with false (without acks), preventing acknowledgements from completing upstream. Since the DLQ pipeline exists specifically to drain failed events, blocking it under memory pressure defeats its purpose and can cascade into negative acknowledgements on the source pipeline's Kafka buffer. Skip applying CircuitBreakingBuffer to HeadlessPipelineSource pipelines, matching the existing skip for PipelineConnector sources. Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
requested review from
KarstenSchnitter,
Zhangxunmt,
dinujoh,
divbok,
dlvenable,
kkondaka,
oeyh,
san81,
sb2k16,
srikanthjg and
srikanthpadakanti
as code owners
October 7, 2026 17:47
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
dlvenable
reviewed
Oct 8, 2026
dlvenable
left a comment
dlvenable
left a comment
Member
There was a problem hiding this comment.
Thanks @graytaylor0 for this fix!
dlvenable
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DLQ (failure) pipeline uses a HeadlessPipelineSource which writes events to its buffer via sendEvents(). When a circuit breaker is active, the buffer is wrapped with CircuitBreakingBuffer which throws TimeoutException when the breaker is open.
This causes DLQ writes to block indefinitely (with acks enabled) or release with false (without acks), preventing acknowledgements from completing upstream. Since the DLQ pipeline exists specifically to drain failed events, blocking it under memory pressure defeats its purpose and can cascade into negative acknowledgements on the source pipeline's Kafka buffer or end to end acknowledgments with something like S3 or DynamoDB sources.
Skip applying CircuitBreakingBuffer to HeadlessPipelineSource pipelines, matching the existing skip for PipelineConnector sources.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.