Repository navigation
Retire PHP 7 and harden PHP 8 - #325
Merged
Merged
Conversation
PHP 7 is end of life and should no longer be offered as a maintained OpenFaaS template. Remove it and disable PHP session upload progress in PHP 8, where Classic Watchdog passes request bodies to the CLI over stdin and does not use the feature. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
AI Pull Request OverviewDisclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification. Summary
Approval rating (1-10)10/10. The retirement is internally complete, and the PHP 8 hardening is narrowly scoped and consistent with the template's request-processing model. Summary per fileSummary per file
Overall AssessmentThe changes are ready to merge. The PHP 7 removal covers the template implementation and its repository-level catalog entry without leaving stale references. The PHP 8 configuration is applied through PHP's standard Detailed ReviewDetailed ReviewNo findings. AI agent details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 7 is end of life but remains in the maintained template repository. Remove the PHP 7 template and disable PHP session upload progress in PHP 8 as defence in depth; Classic Watchdog invokes PHP CLI and passes request bodies over stdin, so the feature is unused.
Validation: