Repository navigation
Remove PHP 7 from template store - #168
Merged
Merged
Conversation
PHP 7 is end of life and no longer belongs in the list of supported OpenFaaS templates. Remove its entry while retaining PHP 8 as the recommended PHP template. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
AI Pull Request OverviewDisclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification. Summary
Approval rating (1-10)10/10. The focused removal is internally consistent and preserves the supported PHP replacement. Summary per fileSummary per file
Overall AssessmentThe change is appropriately scoped to removing the obsolete Template Store entry. The remaining PHP 8 entry continues to be marked official and recommended, and no repository references to PHP 7 remain. Detailed ReviewDetailed ReviewNo findings. AI agent details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 7 is end of life and is being removed from the maintained OpenFaaS templates in openfaas/templates#325. Remove its Template Store entry while retaining PHP 8 as the official, recommended PHP template.
Validation: