[WIP] Add node-local delayed resume to ProcessorInbox#2471
Draft
lquerel wants to merge 31 commits intoopen-telemetry:mainfrom
Draft
[WIP] Add node-local delayed resume to ProcessorInbox#2471lquerel wants to merge 31 commits intoopen-telemetry:mainfrom
lquerel wants to merge 31 commits intoopen-telemetry:mainfrom
Conversation
# Conflicts: # rust/otap-dataflow/crates/engine/src/message.rs # rust/otap-dataflow/crates/engine/src/processor.rs
# Conflicts: # rust/otap-dataflow/crates/engine/src/message.rs # rust/otap-dataflow/crates/engine/src/processor.rs
5 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2471 +/- ##
==========================================
- Coverage 88.35% 88.21% -0.14%
==========================================
Files 603 608 +5
Lines 212379 216476 +4097
==========================================
+ Hits 187646 190971 +3325
- Misses 24207 24979 +772
Partials 526 526
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not ready for review. #2470 must be merged first to reduce the scope of this PR
Change Summary
Add node-local delayed
pdataresume for processors viarequeue_later(...)and integrate it intoProcessorInbox.This PR extends the node-local scheduler work from the previous PR by adding a bounded local delayed-resume reservoir for
pdata. Due delayed resumes are delivered back throughProcessorInbox, andretry_processoris migrated off the old global delayed-data path.This is the next step in the redesign tracked in #2465. After PR3 separated wakeup-style local scheduling from delayed
pdatahandling, this PR addresses the delayedpdataside directly.The goal is to move retry-style deferred work out of the global runtime path and into node-local inbox orchestration, while keeping the old global delayed-data plumbing in place temporarily for compatibility. That keeps this PR focused on local delayed resume and retry migration only; the cleanup and removal of the old global path happens in the next PR.
What issue does this PR close?
How are these changes tested?
ProcessorInboxrequeue_later(...)cargo xtask checkAre there any user-facing changes?
No user-facing changes.
This PR is an internal runtime change only.