[WIP] Remove global delayed-data runtime plumbing#2472
Draft
lquerel wants to merge 32 commits intoopen-telemetry:mainfrom
Draft
[WIP] Remove global delayed-data runtime plumbing#2472lquerel wants to merge 32 commits intoopen-telemetry:mainfrom
lquerel wants to merge 32 commits intoopen-telemetry:mainfrom
Conversation
# Conflicts: # rust/otap-dataflow/crates/engine/src/message.rs # rust/otap-dataflow/crates/engine/src/processor.rs
# Conflicts: # rust/otap-dataflow/crates/engine/src/message.rs # rust/otap-dataflow/crates/engine/src/processor.rs
5 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2472 +/- ##
==========================================
- Coverage 88.35% 88.17% -0.19%
==========================================
Files 603 608 +5
Lines 212379 215944 +3565
==========================================
+ Hits 187646 190403 +2757
- Misses 24207 25015 +808
Partials 526 526
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not ready for review. #2471 must be merged first to reduce the scope of this PR
Change Summary
Remove the old runtime-managed delayed-data path now that node-local wakeups and node-local delayed resume are in place.
This PR deletes the remaining global delayed-data plumbing from the engine, including the runtime control path and the delayed-data-specific node control message flow. After the previous PRs:
ProcessorInboxpdataresume is handled locally viarequeue_later(...)This is the cleanup step in the redesign tracked in #2465. It simplifies the runtime manager, reduces global contention, and makes shutdown behavior easier to reason about by removing delayed-data-specific special cases from the global control path.
What issue does this PR close?
How are these changes tested?
delayed-data path
cargo xtask checkAre there any user-facing changes?
No user-facing changes.
This PR is an internal runtime cleanup only.