Repository navigation
Rename the library from notty to notty-community #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| (executable | ||
| (name speed) | ||
| (libraries notty notty.unix common unmark unmark.cli)) | ||
| (libraries notty-community notty-community.unix common unmark unmark.cli)) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,5 @@ | ||
| (lang dune 3.0) | ||
| (name notty) | ||
| (name notty-community) | ||
|
|
||
| (formatting disabled) | ||
| (generate_opam_files true) | ||
|
|
||
| (source (github ocaml-community/notty)) | ||
| (maintainers | ||
| "Ali Caglayan <alizter@gmail.com>" | ||
| "Antonin Décimo <antonin@tarides.com>" | ||
| "Romain Calascibetta <romain.calascibetta@gmail.com>") | ||
| (authors "David Kaloper <dk505@cam.ac.uk>") | ||
| (license "ISC") | ||
|
|
||
| (package | ||
| (name notty) | ||
| (synopsis "Declaring terminals") | ||
| (description "Notty is a declarative terminal library for OCaml structured around a notion of composable images. It tries to abstract away the basic terminal programming model, providing something simpler and more expressive.") | ||
| (depends | ||
| (ocaml (>= 4.08.0)) | ||
| (cppo (and :build (>= 1.1.0))) | ||
| (uutf (>= 1.0.0))) | ||
| (depopts | ||
| lwt) | ||
| (conflicts | ||
| (lwt (< 2.6.0)))) | ||
| (generate_opam_files false) | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,17 +1,21 @@ | ||||||
| # This file is generated by dune, edit dune-project instead | ||||||
| opam-version: "2.0" | ||||||
| synopsis: "Declaring terminals" | ||||||
| description: | ||||||
| "Notty is a declarative terminal library for OCaml structured around a notion of composable images. It tries to abstract away the basic terminal programming model, providing something simpler and more expressive." | ||||||
| description: """ | ||||||
| Notty is a declarative terminal library for OCaml structured around a notion | ||||||
| of composable images. It tries to abstract away the basic terminal | ||||||
| programming model, providing something simpler and more expressive. | ||||||
|
|
||||||
| This is a branch from the original notty, maintained by the community. | ||||||
| """ | ||||||
| maintainer: [ | ||||||
| "Ali Caglayan <alizter@gmail.com>" | ||||||
| "Antonin Décimo <antonin@tarides.com>" | ||||||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
if i'm understanding correctly? @Alizter do you want to be removed too or are you fine maintaining it?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm fine with staying as a maintainer. |
||||||
| "Romain Calascibetta <romain.calascibetta@gmail.com>" | ||||||
|
Comment on lines
11
to
13
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess this needs to be updated? Or are these people still available to maintain this package?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For my part, I'm available 👍 |
||||||
| ] | ||||||
| authors: ["David Kaloper <dk505@cam.ac.uk>"] | ||||||
| license: "ISC" | ||||||
| homepage: "https://github.com/ocaml-community/notty" | ||||||
| bug-reports: "https://github.com/ocaml-community/notty/issues" | ||||||
| homepage: "https://github.com/ocaml-community/notty-community" | ||||||
| bug-reports: "https://github.com/ocaml-community/notty-community/issues" | ||||||
| depends: [ | ||||||
| "dune" {>= "3.0"} | ||||||
| "ocaml" {>= "4.08.0"} | ||||||
|
|
@@ -37,4 +41,4 @@ build: [ | |||||
| "@doc" {with-doc} | ||||||
| ] | ||||||
| ] | ||||||
| dev-repo: "git+https://github.com/ocaml-community/notty.git" | ||||||
| dev-repo: "git+https://github.com/ocaml-community/notty-community.git" | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| (library | ||
| (public_name notty.lwt) | ||
| (public_name notty-community.lwt) | ||
| (synopsis "Notty Lwt+Unix IO") | ||
| (name notty_lwt) | ||
| (wrapped false) | ||
| (optional) | ||
| (libraries notty notty.unix lwt lwt.unix)) | ||
| (libraries notty-community notty-community.unix lwt lwt.unix)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the benefit of removing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is personal preference on account of this feature being devoid of value past the initial generation, duplicating all the informations over two files and making it harder to contribute changes to the opam file.