Repository navigation
Rename the library from notty to notty-community - #9
Conversation
|
cc @MisterDA (you're not watching this repository apparently) |
|
Thanks for you work, @kit-ty-kate do you have the right on this repository? If so, I'm ok with this PR (but you should take into account #6 which seems required for dune). If not and if @MisterDA does not have the time to do, I can take the relay. |
i do |
|
I wish I had the time... I don't have an immediate use for notty anymore, and my plate is so full it reminds me of my grandma's after school snacks. Sorry for not pursuing this and thank you for taking over! |
shonfeder
left a comment
shonfeder
left a comment
There was a problem hiding this comment.
Seems OK to me.
I have also kind of lost my immediate window of availability to do an initial maintenance push here. Thanks for moving this forward, @kit-ty-kate
| (name notty-community) | ||
|
|
||
| (formatting disabled) | ||
| (generate_opam_files true) |
There was a problem hiding this comment.
What's the benefit of removing this?
There was a problem hiding this comment.
this is personal preference on account of this feature being devoid of value past the initial generation, duplicating all the informations over two files and making it harder to contribute changes to the opam file.
| "Ali Caglayan <alizter@gmail.com>" | ||
| "Antonin Décimo <antonin@tarides.com>" | ||
| "Romain Calascibetta <romain.calascibetta@gmail.com>" |
There was a problem hiding this comment.
I guess this needs to be updated? Or are these people still available to maintain this package?
There was a problem hiding this comment.
For my part, I'm available 👍
Co-authored-by: Shon Feder <shon.feder@gmail.com>
| """ | ||
| maintainer: [ | ||
| "Ali Caglayan <alizter@gmail.com>" | ||
| "Antonin Décimo <antonin@tarides.com>" |
There was a problem hiding this comment.
| "Antonin Décimo <antonin@tarides.com>" | |
| "Shon Feder <shon.feder@gmail.com>" |
if i'm understanding correctly? @Alizter do you want to be removed too or are you fine maintaining it?
There was a problem hiding this comment.
I'm fine with staying as a maintainer.
|
Since OCaml 5.4 is out, i'm merging this as-is and will do a release at 7pm UTC today. If you have any concerns please do create an issue or tell me to stop the release process. |
Per discussion in ocaml-community/meta#46
I'm planning to do a release with pqwy#58 after that.
I don't think we need to rename the module names as notty comes rarely low in the dependency tree and thus conflicts with other libraries that would use the original version of
nottyseems unlikely.