Skip to content

feat: add guidance for fetching all GitHub PR comment types (issue #701) #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ElizioMartins wants to merge 1 commit into
base: dev
Choose a base branch
from
+19 −0
Open

feat: add guidance for fetching all GitHub PR comment types (issue #701) #1729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions skills/receiving-code-review/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,25 @@ You understand 1,2,3,6. Unclear on 4,5.
✅ RIGHT: "I understand items 1,2,3,6. Need clarification on 4 and 5 before proceeding."
```

## Fetching GitHub PR Feedback

When receiving feedback via GitHub PR, you MUST fetch ALL THREE comment types before beginning evaluation. Missing any type risks overlooking significant feedback.

```bash
# 1. Inline review comments (line-specific annotations)
gh api repos/{owner}/{repo}/pulls/{pr}/comments

# 2. Review bodies (summary text + nitpick sections posted with each review)
gh api repos/{owner}/{repo}/pulls/{pr}/reviews

# 3. Direct PR comments (top-level conversation, often bots post here)
gh api repos/{owner}/{repo}/issues/{pr}/comments
```

**Note:** The `issues/{pr}/comments` endpoint works because GitHub PRs are a superset of issues.

**Do NOT rely solely on `gh pr view` or the inline comments endpoint** — they miss review bodies and top-level comments which often contain the most significant feedback (security reviews, architectural summaries, bot findings).

## Source-Specific Handling

### From your human partner
Expand Down