Skip to content

feat: add guidance for fetching all GitHub PR comment types (issue #701)#1729

Open
ElizioMartins wants to merge 1 commit into
obra:devfrom
ElizioMartins:feat/receiving-code-review-github-comments
Open

feat: add guidance for fetching all GitHub PR comment types (issue #701)#1729
ElizioMartins wants to merge 1 commit into
obra:devfrom
ElizioMartins:feat/receiving-code-review-github-comments

Conversation

@ElizioMartins

Copy link
Copy Markdown

Who is submitting this PR?

Field Value
Your model + version Nemotron 3 Ultra (via OpenCode)
Harness + version OpenCode (latest)
All plugins installed superpowers
Human partner who reviewed this diff Elizio Martins

What problem are you trying to solve?

Issue #701: The receiving-code-review skill's step 1 ("READ: Complete feedback without reacting") doesn't specify how to fetch all feedback. In practice, agents using gh CLI may only fetch inline review comments and miss other comment types that often contain the most significant feedback.

What does this PR change?

Adds a new "Fetching GitHub PR Feedback" section to the skill with explicit commands for all three GitHub PR comment types:

  1. Inline review comments (line-specific): gh api repos/{owner}/{repo}/pulls/{pr}/comments
  2. Review bodies (summary + nitpicks): gh api repos/{owner}/{repo}/pulls/{pr}/reviews
  3. Direct PR comments (top-level): gh api repos/{owner}/{repo}/issues/{pr}/comments

Includes warning against relying solely on gh pr view or inline comments endpoint.

Is this change appropriate for the core library?

Yes - this affects all users receiving code review feedback via GitHub PRs, regardless of project domain.

What alternatives did you consider?

Alternative would be to auto-fetch in a script, but the skill should teach the agent the correct commands to use.

Does this PR contain multiple unrelated changes?

No - single cohesive addition to the skill.

Existing PRs

Environment tested

Harness Harness version Model Model version/ID
OpenCode latest Nemotron 3 Ultra nemotron-3-ultra-free

Evaluation

Rigor

  • This change was tested adversarially, not just on the happy path
  • I did not modify carefully-tuned content (Red Flags table, rationalizations, "human partner" language)

Human review

  • A human has reviewed the COMPLETE proposed diff before submission

…ra#701)

Add 'Fetching GitHub PR Feedback' section to receiving-code-review skill with explicit commands for all three comment types:
1. Inline review comments (line-specific): gh api repos/{owner}/{repo}/pulls/{pr}/comments
2. Review bodies (summary + nitpicks): gh api repos/{owner}/{repo}/pulls/{pr}/reviews
3. Direct PR comments (top-level): gh api repos/{owner}/{repo}/issues/{pr}/comments

Warns against relying solely on 'gh pr view' or inline comments endpoint which miss review bodies and top-level comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant