Repository navigation
Infinite scroll, and read markers that follow you across clients - #309
Open
matheusfillipe wants to merge 46 commits into
Open
matheusfillipe wants to merge 46 commits into
matheusfillipe wants to merge 46 commits into
Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 165 files, which is 65 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configuration
⛔ Files ignored due to path filters: 1
📒 Files selected for processing: 165
You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
matheusfillipe
added this pull request to stack #308
October 12, 2026 11:27
|
Automated deployment preview for the PR in the Cloudflare Pages. |
matheusfillipe
marked this pull request as ready for review
October 14, 2026 11:18
matheusfillipe
force-pushed
the
stack/infinite-scroll
branch
from
October 16, 2026 19:15
0e2dce1 to
8d5f2b6
Compare
…g the reader sheet
…and keep fillable gaps out of view
…messages only while the app is focused
…etes with an in-app dialog
… tooltips on wide anchors
…joins the server refuses
…ld workflow and player places
…he buttons for touch
…channel names case-insensitively
…es and fix stale imports
…s without duplicates
… the new messages line from moving messages
… once more history turns up
… and keep unseen messages unread while history is late
…rk our own lines read at the server's time
… reading place while pages fill in
matheusfillipe
force-pushed
the
stack/infinite-scroll
branch
from
October 16, 2026 20:05
8d5f2b6 to
660c4d1
Compare
ValwareIRC
previously approved these changes
Oct 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading back in a channel meant clicking "Load older messages" over and over, and opening Obby on another device always dropped you at the bottom.
Now history loads as you scroll, both up and down, with skeleton rows while it arrives. Chats open on a red New messages line at the last message you actually read, shared between your clients through draft/read-marker. The marker only moves while you are looking at the newest messages.
Where to look:
ChannelMessageList.tsx: loading at either edge replaces the load button, one arrow takes you to the bottom (or back to the present after a search jump), and the unread line.store/handlers/readMarker.ts: when we sendMARKREAD(app visible, at the bottom, stored marker known) and what an incoming one clears.store/handlers/history.ts: older channel pages go to the local history first and are shown from there.Channel markers need obbyworld/ObbyIRCd#26. Until it is deployed, only private chats get them.