Skip to content

chore: minor code review

a56d7a5
Select commit
Loading
Failed to load commit list.
Merged

feat: add reduce metrics for rust data plane #3364

chore: minor code review
a56d7a5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 2, 2026 in 1s

82.51% (-0.03%) compared to ce2ac17

View this Pull Request on Codecov

82.51% (-0.03%) compared to ce2ac17

Details

Codecov Report

❌ Patch coverage is 88.72549% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.51%. Comparing base (ce2ac17) to head (a56d7a5).

Files with missing lines Patch % Lines
...aflow-core/src/reduce/reducer/unaligned/reducer.rs 64.44% 16 Missing ⚠️
...umaflow-core/src/reduce/reducer/aligned/reducer.rs 87.23% 6 Missing ⚠️
rust/numaflow-core/src/metrics/mod.rs 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3364      +/-   ##
==========================================
- Coverage   82.53%   82.51%   -0.03%     
==========================================
  Files         307      307              
  Lines       75325    75527     +202     
==========================================
+ Hits        62172    62320     +148     
- Misses      12595    12652      +57     
+ Partials      558      555       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.