Repository navigation
Conversation
Affinity 3.3 merged ReflectedLayoutItemTemplates.xaml into ContextBarItemTemplates.xaml. Its implicit CheckedComboBoxItem style has an empty ControlTemplate, and the merged dictionary is searched before the application's Core.xaml, so LeadingComboItemStyle and CheckedComboBoxItemStyle (BasedOn the implicit style, no template of their own) inherit nothing. The Leading dropdown opens with zero height. Replacing the dictionary entries is not enough, because the context bar's DataTemplates keep the style objects their StaticResource references were bound to. Instead, when a CheckedComboBox applies its template, swap an ItemContainerStyle whose inherited template is empty for a copy BasedOn Core.xaml's style. Styles with a real template are untouched, and the patch does nothing once the XAML is fixed. Affinity 3.2.3 does not have the merge.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affinity 3.3 opens the text context toolbar's Leading dropdown with nothing in it, and this fixes it.
Affinity 3.3 merged ReflectedLayoutItemTemplates.xaml into ContextBarItemTemplates.xaml. The merged dictionary's implicit CheckedComboBoxItem style has an empty ControlTemplate, and it is searched before Core.xaml. So
LeadingComboItemStyleandCheckedComboBoxItemStyle, which are BasedOn the implicit style, inherit an empty template, and the list opens with zero height.Replacing the dictionary entries doesn't help, because the context bar's DataTemplates keep the style objects they were bound to. Instead, when a CheckedComboBox applies its template, an ItemContainerStyle whose inherited template is empty is swapped for a copy BasedOn Core.xaml's style. Styles with a real template are untouched. The patch does nothing once Affinity's XAML is fixed, and Affinity 3.2.3 doesn't have the merge.
It is a new setting, "Context toolbar: Fix empty Leading dropdown", on by default. It's one commit on
dev, independent of #61, #62 and the color picker PR.Tested with Affinity 3.3 on Wine 11.19.