Repository navigation
Conversation
The sub-tool panel is a ToolTray like the main tool pane. Its column count comes from SubToolPanel.ToggleVisibility on every tool change (two for more than ten sub-tools), but a studio switch raises CurrentWorkspaceChanged, and every ToolTray handles that by setting Columns to the main tool pane's ToolPaneColumns. With a one-column tool pane, the shape tools came back as a single column running the height of the window until the next tool change. After that handler, the sub-tool panel's tray gets its own rule back; the main tool pane is left alone. Checked with three Pixel/Layout round trips: two columns each time, one before.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a studio switch, the sub-tool panel (the shape tools, for example) comes back as a single column running the height of the window, and goes back to two columns only on the next tool change. This fixes it.
The sub-tool panel is a
ToolTray, like the main tool pane.SubToolPanel.ToggleVisibilitysets its column count on every tool change: two for more than ten sub-tools, otherwise one. But a studio switch raisesCurrentWorkspaceChanged, and everyToolTrayhandles that by settingColumnsto the main tool pane'sToolPaneColumns. With a one-column tool pane, the shape tools end up in one column.A postfix on
ToolTray.WorkspaceService_CurrentWorkspaceChangedapplies the sub-tool panel's own rule again when the tray is the tool host'sSubToolRoot. The main tool pane is left alone. Everything is reached by reflection, so the patch skips itself if those members change.It is a new setting, "Sub-tool panel: Keep its columns across studio switches", on by default, and it's in the configuration docs. It's one commit on
dev, independent of #61, #62, #64 and #65.Tested with Affinity 3.3 on Wine 11.19: three Pixel/Layout round trips kept two columns each time; before, one Pixel → Layout switch gave one column.