Skip to content

Use sanitized snapshots for gcta/makegrmpart tests#11764

Open
lyh970817 wants to merge 1 commit into
nf-core:masterfrom
lyh970817:modules/gcta-makegrmpart-sanitize-snapshots
Open

Use sanitized snapshots for gcta/makegrmpart tests#11764
lyh970817 wants to merge 1 commit into
nf-core:masterfrom
lyh970817:modules/gcta-makegrmpart-sanitize-snapshots

Conversation

@lyh970817
Copy link
Copy Markdown
Contributor

@lyh970817 lyh970817 commented May 26, 2026

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs?
  • If necessary, also make a PR on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core modules lint gcta/makegrmpart).
  • Ensure the test works with either Docker / Singularity. Conda CI tests can be quite slow; please only use them if you need them.

This updates the gcta/makegrmpart nf-test assertions to snapshot the sanitized full process.out object instead of manually snapshotting selected channels and versions. The updated snapshots now cover the complete emitted output contract for each successful test while keeping the tests simpler.

Tested with:

  • nf-test test modules/nf-core/gcta/makegrmpart/tests/main.nf.test --profile=docker --update-snapshot --verbose

@lyh970817 lyh970817 requested a review from SPPearce May 26, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant