feat: support task.ext.args in sentieon/gvcftyper#11763
Open
nicorap wants to merge 2 commits into
Open
Conversation
Mirrors the convention used by sibling sentieon modules (haplotyper, varcal, applyvarcal). The injection point is after `--algo GVCFtyper` so callers pass algorithm-level options (e.g. `--emit_mode all_samples`, `--call_conf`, `--allow-old-rms-mapping-quality-annotation-data`). Use case: nf-core/sarek's joint-germline workflow can now configure a two-pass sharded GVCFtyper (SHARD with `--emit_mode all_samples`, REDUCE with default emit) for cohorts that exceed single-pass RAM limits, without forking the module.
SPPearce
approved these changes
May 26, 2026
Contributor
|
The GitHub actions seem to be down at the moment |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
task.ext.argssupport toSENTIEON_GVCFTYPER, matching the convention already used by sibling sentieon modules (haplotyper,varcal,applyvarcal,dnascope,applyvarcal, etc.).${args}is injected after--algo GVCFtyper, so callers pass algorithm-level options (--emit_mode,--call_conf,--allow-old-rms-mapping-quality-annotation-data, etc.). Driver-level flags (-t,--interval) remain managed by the module since they relate to inputs themodule already owns.
Reason for PR
nf-core/sarek's joint-germline path needs to call GVCFtyper in two distinct modes for very large cohorts:--emit_mode all_samplesto produce batch-aggregated intermediatesWithout
ext.argssupport, sarek currently has to ship a local fork of the module (modules/local/sentieon/gvcftyper/) that's identical to the upstream moduleexcept for these two lines. This PR removes that need.
Tests
No new tests added — the change is a no-op when
task.ext.argsis unset (the default), which is what every existing test exercises. They continue to passunchanged.
PR checklist
docs — N/A, existing module
topic: versions— unchangedlabel—label 'process_high'already presentnf-core modules test sentieon/gvcftyper --profile dockernf-core modules test sentieon/gvcftyper --profile singularitynf-core modules test sentieon/gvcftyper --profile conda