Skip to content

feat(core): Include workflow names on instance AI confirmations (no-changelog) (backport to release-candidate/2.18.x)#28792

Merged
Cadiac merged 1 commit into
release-candidate/2.18.xfrom
backport-28719-to-release-candidate/2.18.x
Apr 21, 2026
Merged

feat(core): Include workflow names on instance AI confirmations (no-changelog) (backport to release-candidate/2.18.x)#28792
Cadiac merged 1 commit into
release-candidate/2.18.xfrom
backport-28719-to-release-candidate/2.18.x

Conversation

@n8n-assistant
Copy link
Copy Markdown
Contributor

@n8n-assistant n8n-assistant Bot commented Apr 21, 2026

Description

Backport of #28719 to release-candidate/2.18.x.

Checklist for the author (@Cadiac) to go through.

  • Review the backport changes
  • Fix possible conflicts
  • Merge to target branch

After this PR has been merged, it will be picked up in the next patch release for release track.

Original description

Summary

Make sure we display the workflow name on HITL confirmations on instance AI.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • I have seen this code, I have run this code, and I take responsibility for this code.
  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with Backport to Beta, Backport to Stable, or Backport to v1 (if the PR is an urgent fix that needs to be backported)

…hangelog) (#28719)

Co-authored-by: Albert Alises <[email protected]>
(cherry picked from commit 86ceb68)
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Architecture diagram
sequenceDiagram
    participant Agent as AI Agent
    participant Tool as Tool (Workflow/Execution)
    participant WFS as Workflow Service
    participant User as HITL / UI

    Note over Agent,User: Action Request (e.g., Run, Delete, Publish)

    Agent->>Tool: execute(action, workflowId)
    
    Note over Tool: Check if action needs approval
    
    alt Approval Required & First Execution
        Tool->>WFS: NEW: get(workflowId)
        
        alt Success
            WFS-->>Tool: Return Workflow (name, id)
        else Error / Not Found
            WFS-->>Tool: Error
            Tool->>Tool: Fallback to workflowId for display
        end

        Tool->>User: NEW: suspend(message with Workflow Name)
        Note right of User: User sees: "Execute workflow 'My Workflow' (ID: wf-1)?"
    else Permission granted OR Resuming from approval
        alt Action: Run
            Tool->>Tool: Execute workflow
        else Action: Delete/Publish
            Tool->>WFS: Perform lifecycle update
        end
        Tool-->>Agent: Return success result
    end
Loading

@github-actions
Copy link
Copy Markdown
Contributor

Instance AI Workflow Eval Results

8/8 built | 15/27 passed (55%)

Workflow Build Passed
Create a workflow that handles contact form submissions via a webhook. 4/5
Get all the Linear issues created in the last 2 weeks. Filter them for 2/5
Every day, get the posts made in the past day on 3 different Slack cha 3/5
Create a form that collects: name, email, company, and interest level 2/2
Every day, fetch all open GitHub issues from repository 'acme-corp/bac 0/2
Create a workflow that receives webhook notifications with a JSON body 3/3
Fetch the latest posts from the JSONPlaceholder API (GET https://jsonp 1/3
Every hour, check the current weather for London, New York, and Tokyo 0/2
Failure details

partial-action-failure [builder_issue]

The Telegram Notification node failed with 'Bad request - please check your parameters' (triggered by the mock returning {ok: false, error_code: 400, description: 'Bad Request: chat not found'}), and

happy-path [builder_issue]

The workflow executed without errors and posted to Slack, but the cross-team filtering produced zero results instead of the expected 4 cross-team issues (Alice: 3, Bob: 1). The root cause is in the Fi

multi-team-creator [builder_issue]

The checklist requires: (1) Alice's AI issue excluded (correct), (2) Alice has more cross-team issues than Bob, (3) report sorted descending with Alice first. Instead, the Filter Cross-Team Issues nod

api-error [builder_issue]

The workflow has no error handling branch. When the Linear API returns an authentication error (401), the 'Fetch Linear Issues' node crashes with 'Authentication required: Invalid or expired API token

channel-not-found [builder_issue]

The workflow crashed entirely when 'Get #product Messages' returned a channel_not_found error. There is no error handling in the workflow — no try/catch, no error branch, no continueOnFail setting on

insufficient-permissions [builder_issue]

The workflow crashed when 'Get #product Messages' returned a 403 error. There is no error handling configured (no try/catch, no error branch, no 'Continue On Fail' setting) on that node. The 403 cause

happy-path [builder_issue]

The workflow failed to execute because the 'Split Issues' node has a misconfigured 'Fields To Split Out' parameter — it is set to an empty string when it is required. This caused the execution to fail

no-bugs [builder_issue]

The workflow failed to execute cleanly. The 'Split Issues' node has a missing required parameter: 'Fields To Split Out' is empty. This caused the execution to fail with 'The workflow has issues and ca

happy-path [builder_issue]

The workflow did not execute completely. While Manual Trigger, Fetch Posts, and Split Posts ran, the Filter Out qui, Build Summary, and Post to Slack nodes all did not run. The Split Posts node is con

all-filtered [builder_issue]

The Filter Out qui node was supposed to filter OUT posts containing 'qui' in the title, but its output shows all 3 posts still present — including posts with 'qui' in their titles ('qui est esse', 'ut

happy-path [builder_issue]

The workflow failed to execute. The pre-analysis flags a builder issue: 'Log to Airtable' has an invalid Airtable Table ID ('Weather Logs' is a plain text name, not a valid table ID which should be in

no-alerts [builder_issue]

The workflow failed to execute. The pre-analysis flagged a builder issue: the 'Log to Airtable' node has an invalid Airtable Table ID — 'Weather Logs' is a display name, not a valid table ID (which sh

@github-actions
Copy link
Copy Markdown
Contributor

Performance Comparison

Comparing currentlatest master14-day baseline

Idle baseline with Instance AI module loaded

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
instance-ai-heap-used-baseline 186.84 MB 186.52 MB 186.43 MB (σ 0.26) +0.2% +0.2% ⚠️
instance-ai-rss-baseline 385.82 MB 389.20 MB 366.52 MB (σ 22.66) -0.9% +5.3%

docker-stats

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
docker-image-size-n8n 1269.76 MB 1269.76 MB 1273.60 MB (σ 10.49) +0.0% -0.3%
docker-image-size-runners 386.00 MB 386.00 MB 392.50 MB (σ 11.06) +0.0% -1.7%

Memory consumption baseline with starter plan resources

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
memory-rss-baseline 351.56 MB 278.98 MB 289.99 MB (σ 41.20) +26.0% +21.2% ⚠️
memory-heap-used-baseline 114.27 MB 114.41 MB 114.45 MB (σ 0.27) -0.1% -0.2%
How to read this table
  • Current: This PR's value (or latest master if PR perf tests haven't run)
  • Latest Master: Most recent nightly master measurement
  • Baseline: Rolling 14-day average from master
  • vs Master: PR impact (current vs latest master)
  • vs Baseline: Drift from baseline (current vs rolling avg)
  • Status: ✅ within 1σ | ⚠️ 1-2σ | 🔴 >2σ regression

@Cadiac Cadiac merged commit 5286afc into release-candidate/2.18.x Apr 21, 2026
53 checks passed
@Cadiac Cadiac deleted the backport-28719-to-release-candidate/2.18.x branch April 21, 2026 12:16
@n8n-assistant
Copy link
Copy Markdown
Contributor Author

n8n-assistant Bot commented Apr 22, 2026

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant