Skip to content

feat(core): Include workflow names on instance AI confirmations (no-changelog)#28719

Merged
aalises merged 2 commits into
masterfrom
instance-ai-confirmation-wf-names
Apr 21, 2026
Merged

feat(core): Include workflow names on instance AI confirmations (no-changelog)#28719
aalises merged 2 commits into
masterfrom
instance-ai-confirmation-wf-names

Conversation

@Cadiac
Copy link
Copy Markdown
Contributor

@Cadiac Cadiac commented Apr 20, 2026

Summary

Make sure we display the workflow name on HITL confirmations on instance AI.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • I have seen this code, I have run this code, and I take responsibility for this code.
  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with Backport to Beta, Backport to Stable, or Backport to v1 (if the PR is an urgent fix that needs to be backported)

@Cadiac Cadiac requested a review from aalises April 20, 2026 15:19
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Architecture diagram
sequenceDiagram
    participant Agent as AI Agent
    participant Tool as Instance AI Tool<br/>(Workflows/Executions)
    participant WfSvc as Workflow Service
    participant DB as Database

    Note over Agent,DB: HITL Confirmation Flow (e.g., Run, Delete, Publish)

    Agent->>Tool: execute(input)
    Note right of Tool: input.workflowId provided
    
    alt Needs Approval & No resumeData
        Tool->>WfSvc: NEW: get(workflowId)
        
        alt Workflow Found
            WfSvc->>DB: Fetch record
            DB-->>WfSvc: Workflow Object
            WfSvc-->>Tool: Return { name, id, ... }
        else Workflow Missing/Error
            WfSvc-->>Tool: Error / Exception
            Tool->>Tool: NEW: Fallback to workflowId
        end

        Tool->>Tool: CHANGED: Format message with Name and ID
        
        Tool->>Agent: suspend({ message, requestId, severity })
        Note left of Agent: UI displays confirmation to user
    else Permission "always_allow" OR resumeData present
        Tool->>Tool: Proceed with action (run/delete/etc.)
        Tool-->>Agent: Action Result
    end
Loading

@n8n-assistant n8n-assistant Bot added the n8n team Authored by the n8n team label Apr 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

Instance AI Workflow Eval Results

8/8 built | 15/27 passed (55%)

Workflow Build Passed
Create a workflow that handles contact form submissions via a webhook. 4/5
Get all the Linear issues created in the last 2 weeks. Filter them for 2/5
Every day, get the posts made in the past day on 3 different Slack cha 3/5
Create a form that collects: name, email, company, and interest level 2/2
Every day, fetch all open GitHub issues from repository 'acme-corp/bac 0/2
Create a workflow that receives webhook notifications with a JSON body 0/3
Fetch the latest posts from the JSONPlaceholder API (GET https://jsonp 3/3
Every hour, check the current weather for London, New York, and Tokyo 1/2
Failure details

partial-action-failure [builder_issue]

The Telegram node failed with 'Bad request - please check your parameters' (triggered by the mock returning {ok: false, error_code: 400, description: 'Bad Request: chat not found'}), and this caused t

multi-team-creator [builder_issue]

The checklist requires that Alice's AI issue (AI-201) is excluded from the cross-team report, Alice has more cross-team issues than Bob, and the report is sorted descending with Alice first. The Filte

no-cross-team-issues [builder_issue]

The workflow executed without errors, but the cross-team filter did NOT correctly remove all issues. The scenario specifies that all 4 issues are created by people for their own team (Alice→Frontend,

api-error [builder_issue]

The workflow crashed with the error 'Cannot read properties of undefined (reading 'errors')' when the Linear API returned an authentication error. The Fetch Linear Issues node received a valid mock re

channel-not-found [builder_issue]

The workflow crashed entirely when 'Get #product Messages' returned a channel_not_found error. The workflow has no error handling — no try/catch, no error branch, no 'Continue on Error' setting on the

insufficient-permissions [builder_issue]

The workflow crashed when 'Get #product Messages' returned a 'not_in_channel' error. The error propagated and halted the entire workflow — 'Merge Messages', 'Merge Messages 1', 'Summarize with AI', an

happy-path [builder_issue]

The workflow failed to execute. The 'Split Issues' node (n8n-nodes-base.splitOut) has its 'fieldToSplitOut' parameter set to an empty string, which is a required field. This caused the execution to fa

no-bugs [builder_issue]

The workflow failed to execute cleanly. The 'Split Issues' node has a missing required parameter ('Fields To Split Out' is empty string), which caused the execution to fail with 'The workflow has issu

high-priority [builder_issue]

The Switch node ('Route by Level') correctly routed the 'high' level input to its first output (index 0, labeled 'high'), but the connections JSON shows that 'Route by Level' has an empty 'main' array

medium-priority [builder_issue]

The Switch node ('Route by Level') correctly identified the 'medium' level and routed the item to its 'medium' output. However, the connections JSON shows that 'Route by Level' has an empty 'main' arr

low-priority [builder_issue]

The Route by Level switch node correctly identified the 'low' priority and output data on its third branch (index 2, the 'low' output). However, the connections JSON shows that 'Route by Level' has an

happy-path [mock_issue]

The workflow failed due to a mock generation error for the Weather - New York node. The mock response contained {"_evalMockError": true, "message": "Mock generation failed: ..."} instead of valid we

@Cadiac Cadiac requested a review from Tuukkaa April 21, 2026 07:01
@aalises aalises enabled auto-merge April 21, 2026 11:08
@aalises aalises added this pull request to the merge queue Apr 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Performance Comparison

Comparing currentlatest master14-day baseline

Idle baseline with Instance AI module loaded

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
instance-ai-heap-used-baseline 186.89 MB 186.52 MB 186.43 MB (σ 0.26) +0.2% +0.2% ⚠️
instance-ai-rss-baseline 386.88 MB 389.20 MB 366.52 MB (σ 22.66) -0.6% +5.6%

Memory consumption baseline with starter plan resources

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
memory-heap-used-baseline 114.44 MB 114.41 MB 114.45 MB (σ 0.27) +0.0% -0.0%
memory-rss-baseline 282.83 MB 278.98 MB 289.99 MB (σ 41.20) +1.4% -2.5%

docker-stats

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
docker-image-size-n8n 1269.76 MB 1269.76 MB 1273.60 MB (σ 10.49) +0.0% -0.3%
docker-image-size-runners 386.00 MB 386.00 MB 392.50 MB (σ 11.06) +0.0% -1.7%
How to read this table
  • Current: This PR's value (or latest master if PR perf tests haven't run)
  • Latest Master: Most recent nightly master measurement
  • Baseline: Rolling 14-day average from master
  • vs Master: PR impact (current vs latest master)
  • vs Baseline: Drift from baseline (current vs rolling avg)
  • Status: ✅ within 1σ | ⚠️ 1-2σ | 🔴 >2σ regression

Merged via the queue into master with commit 86ceb68 Apr 21, 2026
50 checks passed
@aalises aalises deleted the instance-ai-confirmation-wf-names branch April 21, 2026 11:36
@n8n-assistant
Copy link
Copy Markdown
Contributor

n8n-assistant Bot commented Apr 21, 2026

@n8n-assistant
Copy link
Copy Markdown
Contributor

n8n-assistant Bot commented Apr 28, 2026

Got released with n8n@2.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants