Found a makeshift fix for the pipeline, to prevent it from mass-spamming "Needs-Author-Feedback" labels.#355564
Found a makeshift fix for the pipeline, to prevent it from mass-spamming "Needs-Author-Feedback" labels.#355564DandelionSprout wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Ehm... you could just post a comment and immediately delete that comment to make the bot do that instead. |
|
I feel a strong sense of solidarity with newcomers who don't understand why they're told by the pipelines that it's their fault, and I feel so emotionally sorry for them. |
Fair enough, that label is very generic anyway and can be caused by anything, sometimes it indeed shouldn't need the PR author feedback when the cause wasn't theirs until confirmed manually by the moderators. |
|
@stphengillie, @Trenly, @mdanish-kh thoughts? |
|
Both Needs-Author-Feedback and Needs-Attention have been applied in ways that confuse me for most of my time here. 99% of the "NAF" tickets actually need my attention, and a fair number of "NA" tickets need the author's attention. So my process is to ignore those labels, and @ the author when their attention is needed. Not to sound negative, as I know the current label placement was designed to meet a need, but in a way that isn't clear to me. Which complicates ignoring those tickets that I've already worked. My automation has a "PR Exclude" list, to prevent it from running PRs in the list. (Over and over again, and responding in the PR, hourly for weeks.) |
|
Originally the label for requesting author feedback was added because many authors didn’t test their PRs before they were submitted - leading to many cases where the dependencies were missing or a driver install message showed up. Rather than discontinuing the use of that label, I'm leaning towards actionable information an author could follow in the event we run into one of those problems. My intent is not to confuse PR authors, or to increase the level of effort for our moderators to figure out what's wrong when it's something the PR author should be able to fix. |
|
Chances are the fix could be modified on very short notice after merging, and in fact even before merging (I've got the "Allow edits by maintainers" button turned on for this PR, which to the best of my knowledge is the default setting). I've wondered if I should specify |
|
These labels are applied automatically by the validation pipeline when issues are detected.
These labels are applied by repository maintainers when an issue cannot be automatically validated or requires policy decisions.
|
Checklist for Pull Requests
Manifests
winget validate --manifest <path>?winget install --manifest <path>?Note:
<path>is the directory's name containing the manifest you're submitting.Notes from me:
Validation-Installation-Errorcould be.Microsoft Reviewers: Open in CodeFlow