Skip to content

fix(role): derive accessible name from associated label for meter and progress #41914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aydinomer00 wants to merge 1 commit into from
Closed

fix(role): derive accessible name from associated label for meter and progress #41914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/injected/src/roleUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,6 +843,16 @@ function getTextAlternativeInternal(element: Element, options: AccessibleNameOpt
return compositeString(element.getAttribute('title') || '', element, options.collectElements);
}

// <meter> and <progress> are labelable elements, so use their associated <label>.
// https://github.com/microsoft/playwright/issues/41891
if (!labelledBy && (tagName === 'METER' || tagName === 'PROGRESS')) {
options.visitedElements.add(element);
const labels = (element as HTMLMeterElement | HTMLProgressElement).labels || [];
if (labels.length)
return getAccessibleNameFromAssociatedLabels(labels, options);
return compositeString(element.getAttribute('title') || '', element, options.collectElements);
}

// https://w3c.github.io/html-aam/#input-type-text-input-type-password-input-type-number-input-type-search-input-type-tel-input-type-email-input-type-url-and-textarea-element-accessible-name-computation
// https://w3c.github.io/html-aam/#other-form-elements-accessible-name-computation
// For "other form elements", we count select and any other input.
Expand Down
9 changes: 9 additions & 0 deletions tests/library/role-utils.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,11 @@ test('native controls', async ({ page }) => {

<input id="file1" type=file>
<label for="file2">FILE2</label><input id="file2" type=file>

<label for="meter1">METER1</label><meter id="meter1" value="0.5"></meter>
<meter id="meter2" value="0.5" title="METER2"></meter>
<label for="progress1">PROGRESS1</label><progress id="progress1" value="0.5"></progress>
<progress id="progress2" value="0.5" title="PROGRESS2"></progress>
`);

expect.soft(await getNameAndRole(page, '#text1')).toEqual({ role: 'textbox', name: 'TEXT1' });
Expand All @@ -327,6 +332,10 @@ test('native controls', async ({ page }) => {
expect.soft(await getNameAndRole(page, '#button4')).toEqual({ role: 'button', name: 'BUTTON4' });
expect.soft(await getNameAndRole(page, '#file1')).toEqual({ role: 'button', name: 'Choose File' });
expect.soft(await getNameAndRole(page, '#file2')).toEqual({ role: 'button', name: 'FILE2' });
expect.soft(await getNameAndRole(page, '#meter1')).toEqual({ role: 'meter', name: 'METER1' });
expect.soft(await getNameAndRole(page, '#meter2')).toEqual({ role: 'meter', name: 'METER2' });
expect.soft(await getNameAndRole(page, '#progress1')).toEqual({ role: 'progressbar', name: 'PROGRESS1' });
expect.soft(await getNameAndRole(page, '#progress2')).toEqual({ role: 'progressbar', name: 'PROGRESS2' });
});

test('native controls labelled-by', async ({ page }) => {
Expand Down