fix(role): derive accessible name from associated label for meter and progress#41914
Closed
aydinomer00 wants to merge 1 commit into
Closed
fix(role): derive accessible name from associated label for meter and progress#41914aydinomer00 wants to merge 1 commit into
aydinomer00 wants to merge 1 commit into
Conversation
… progress
<meter> and <progress> are labelable elements, but their accessible name
computation had no branch for the associated <label>, so getByRole({ name })
and toHaveAccessibleName could not match them. Mirror the <output> handling.
Fixes microsoft#41891
Contributor
|
thank you for opening a PR! i think we prefer the solution in #41911 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<meter>and<progress>are labelable elements, but the accessible name computation had no branch for their associated<label>— sogetByRole({ name })andtoHaveAccessibleNamenever matched them.<output>had the same gap (fixed in fix(role): compute <output> accessible name from labels #27415); this mirrors that handling.Fixes #41891