Skip to content

Allow redirect from teams meetings app to work with SameSite=Lax cookie #3230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weilai-irl wants to merge 1 commit into
base: wip-130956-m502
Choose a base branch
from
+18 −0
Open

Allow redirect from teams meetings app to work with SameSite=Lax cookie #3230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions lib/editor/tiny/plugins/teamsmeeting/result.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,24 @@

require_once(__DIR__ . '/../../../../../config.php');

// Cross-site repost handshake for SameSite=Lax compatibility (MDL-83526).
// The external Teams app POSTs back cross-site; the browser withholds the session cookie on
// that request. Rendering a same-site auto-submit form causes the browser to include it on
// the second request, after which require_login() succeeds normally.
if (!empty($_POST['repost'])) {
unset($_POST['repost']);
} else if (!isloggedin()) {
$PAGE->set_context(context_system::instance());
$PAGE->set_pagelayout('popup');
header_remove('Set-Cookie');
$output = $PAGE->get_renderer('mod_lti');
$page = new \mod_lti\output\repost_crosssite_page($_SERVER['REQUEST_URI'], $_POST);
echo $output->header();
echo $output->render($page);
echo $output->footer();
exit;
}

require_login();

$courseid = optional_param('courseid', 0, PARAM_INT);
Expand Down