Allow redirect from teams meetings app to work with SameSite=Lax cookie#3230
Open
weilai-irl wants to merge 1 commit into
Open
Allow redirect from teams meetings app to work with SameSite=Lax cookie#3230weilai-irl wants to merge 1 commit into
weilai-irl wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a “cross-site repost” handshake to the TinyMCE Teams Meeting result endpoint so that when the external Teams app POSTs back cross-site (and the browser omits a SameSite=Lax session cookie), the request is re-posted same-site to allow require_login() to succeed.
Changes:
- Add a pre-
require_login()repost flow which renders an auto-submit form when the user isn’t logged in. - Skip the repost flow on the second request using a
repostPOST flag.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+34
to
+44
| } elseif (!isloggedin()) { | ||
| $PAGE->set_context(context_system::instance()); | ||
| $PAGE->set_pagelayout('popup'); | ||
| header_remove('Set-Cookie'); | ||
| $output = $PAGE->get_renderer('mod_lti'); | ||
| $page = new \mod_lti\output\repost_crosssite_page($_SERVER['REQUEST_URI'], $_POST); | ||
| echo $output->header(); | ||
| echo $output->render($page); | ||
| echo $output->footer(); | ||
| exit; | ||
| } |
weilai-irl
force-pushed
the
wip-131950-m502
branch
from
ac2e83e to
e74fb13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.