Fix undefined property warning when secretexpiryrecipients is absent from the application form#3216
Open
weilai-irl wants to merge 2 commits into
Open
Fix undefined property warning when secretexpiryrecipients is absent from the application form#3216weilai-irl wants to merge 2 commits into
weilai-irl wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adjusts the OIDC application configuration save logic to avoid an “undefined property” warning when secretexpiryrecipients is not present in the submitted form data (e.g., when the related form element is not included).
Changes:
- Only adds
secretexpiryrecipientsto the list of settings-to-save when the submitted form data actually contains that property, preventing$fromform->$configfrom triggering a notice.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.