AUTH_OIDC_IDP_TYPE_OTHER secretexpiryrecipients

[theqoocjil]

field auth_oidc | secretexpiryrecipients used when o365 installed and idp not other, auth_method not secret (from settings.php)
if we have another sit, then moodle raise the warning: "Undefined property: stdClass::$secretexpiryrecipients in manageapplication.php on line 138"

[weilai-irl]

Hi @theqoocjil

Thank you for reporting the issue, and providing the fix. I acknowledge the issue is genuine. After review, I applied a slightly different fix to the issue. Instead of checking explicitly if IdP type is AUTH_OIDC_IDP_TYPE_OTHER in your approach, I checked if $fromform->secretexpiryrecipients is set. This is a more defensive approach and can potentially avoid maintenance work in case more IdP types need to be introduced. The changes are in #3216, #3217, #3218 and #3219, and will be included in the next release.

Regards,
Lai