Populate iconurl with a real URL when $showicon is true#3213
Open
weilai-irl wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the OIDC authcode login flow’s IdP entry returned for the login page to avoid missing icon-related fields when icons are not shown.
Changes:
- When
$showiconis false, explicitly sets$idpentry['iconurl']to an empty string.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
weilai-irl
force-pushed
the
wip-131312-m500
branch
from
f6272a7 to
f6ad171
Compare
weilai-irl
force-pushed
the
wip-131312-m500
branch
from
f6ad171 to
8ff0d57
Compare
weilai-irl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.