Add iconurl icon display on login page#3191
Open
theqoocjil wants to merge 1 commit into
Open
Conversation
Collaborator
|
Hi @theqoocjil Thank you for reporting this. I acknowledge the issue. My original plan was to merge the fix in your PR, however, when reviewing the issue more carefully, I realised that the proper fix is to populate iconurl with a real URL when $showicon is true, since that's what the login UI renders from. I have implemented the solution in PRs #3212 #3213 #3214 #3215 for the supported Moodle versions. They will be included in the next release. Regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@weilai-irl
a mistake was made during the last PR #3123 . You cannot remove the iconurl key, otherwise the error "Warning: Undefined array key "iconurl" in / appearsvar/www/moodle/lib/authlib.php on line 759", because the icon is mandatory in terms of keys. btw, I want to work on PR for the moodle core to fix this misunderstanding.