Skip to content

feat(fence-agents): remove fence-agents-xenapi from metapackage #16464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reubeno merged 1 commit into from
Apr 6, 2026
Merged

feat(fence-agents): remove fence-agents-xenapi from metapackage #16464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion base/comps/components-full.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,6 @@
[components.fedora-iot-config]
[components.felix-parent]
[components.felix-utils]
[components.fence-agents]
[components.festival-freebsoft-utils]
[components.festival]
[components.ffcall]
Expand Down
11 changes: 11 additions & 0 deletions base/comps/fence-agents/fence-agents.comp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
[components.fence-agents]

# Remove fence-agents-xenapi from the fence-agents-all metapackage.
# Xen is not applicable to Azure Linux's Hyper-V/KVM environment.
# Clearing the package name leaves " \\" — a blank continuation that adds
# only harmless whitespace to the Requires list.
[[components.fence-agents.overlays]]
description = "Remove fence-agents-xenapi from fence-agents-all Requires - Xen not needed for Azure Linux"
type = "spec-search-replace"
regex = 'fence-agents-xenapi'
Comment on lines +5 to +10
Copy link

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec-search-replace is currently unscoped and will replace every occurrence of fence-agents-xenapi in the spec. Repo guidance recommends scoping regex overlays with section and package to limit blast radius (see .github/instructions/comp-toml.instructions.md:119-120). Since this is intended to affect only the fence-agents-all subpackage Requires, please scope it accordingly and ensure the replacement also removes any adjacent separators/line-continuation so we don’t rely on a blank \ continuation remaining in the tag value.

Suggested change
# Clearing the package name leaves " \\" — a blank continuation that adds
# only harmless whitespace to the Requires list.
[[components.fence-agents.overlays]]
description = "Remove fence-agents-xenapi from fence-agents-all Requires - Xen not needed for Azure Linux"
type = "spec-search-replace"
regex = 'fence-agents-xenapi'
# Remove the entire dependency entry, including any trailing continuation,
# so the Requires value does not retain an empty "\\" line.
[[components.fence-agents.overlays]]
description = "Remove fence-agents-xenapi from fence-agents-all Requires - Xen not needed for Azure Linux"
type = "spec-search-replace"
section = "%package"
package = "all"
regex = '^[[:space:]]*fence-agents-xenapi([[:space:]][^\\]*)?([[:space:]]*\\)?[[:space:]]*$'

Copilot uses AI. Check for mistakes.
replacement = ''
Loading