feat(fence-agents): remove fence-agents-xenapi from metapackage#16464
feat(fence-agents): remove fence-agents-xenapi from metapackage#16464reubeno merged 1 commit intotomls/base/mainfrom
Conversation
Azure Linux targets Hyper-V/KVM, not Xen. Remove fence-agents-xenapi from the fence-agents-all Requires list so it is no longer pulled in by the metapackage. The subpackage is still built but not installed by default. Verified: build succeeds and fence-agents-all no longer requires fence-agents-xenapi.
There was a problem hiding this comment.
Pull request overview
Removes the Xen-specific fence-agents-xenapi dependency from the fence-agents-all metapackage so Azure Linux (Hyper-V/KVM-focused) no longer pulls it in by default, while still building the subpackage.
Changes:
- Add a dedicated
fence-agents.comp.tomlwith an overlay to removefence-agents-xenapifrom the metapackage Requires. - Remove the now-redundant bare
fence-agentsentry fromcomponents-full.toml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| base/comps/fence-agents/fence-agents.comp.toml | Introduces an overlay intended to drop fence-agents-xenapi from the fence-agents-all Requires. |
| base/comps/components-full.toml | Removes [components.fence-agents] because the component now has a dedicated *.comp.toml file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Clearing the package name leaves " \\" — a blank continuation that adds | ||
| # only harmless whitespace to the Requires list. | ||
| [[components.fence-agents.overlays]] | ||
| description = "Remove fence-agents-xenapi from fence-agents-all Requires - Xen not needed for Azure Linux" | ||
| type = "spec-search-replace" | ||
| regex = 'fence-agents-xenapi' |
There was a problem hiding this comment.
spec-search-replace is currently unscoped and will replace every occurrence of fence-agents-xenapi in the spec. Repo guidance recommends scoping regex overlays with section and package to limit blast radius (see .github/instructions/comp-toml.instructions.md:119-120). Since this is intended to affect only the fence-agents-all subpackage Requires, please scope it accordingly and ensure the replacement also removes any adjacent separators/line-continuation so we don’t rely on a blank \ continuation remaining in the tag value.
| # Clearing the package name leaves " \\" — a blank continuation that adds | |
| # only harmless whitespace to the Requires list. | |
| [[components.fence-agents.overlays]] | |
| description = "Remove fence-agents-xenapi from fence-agents-all Requires - Xen not needed for Azure Linux" | |
| type = "spec-search-replace" | |
| regex = 'fence-agents-xenapi' | |
| # Remove the entire dependency entry, including any trailing continuation, | |
| # so the Requires value does not retain an empty "\\" line. | |
| [[components.fence-agents.overlays]] | |
| description = "Remove fence-agents-xenapi from fence-agents-all Requires - Xen not needed for Azure Linux" | |
| type = "spec-search-replace" | |
| section = "%package" | |
| package = "all" | |
| regex = '^[[:space:]]*fence-agents-xenapi([[:space:]][^\\]*)?([[:space:]]*\\)?[[:space:]]*$' |
Azure Linux targets Hyper-V/KVM, not Xen. Remove fence-agents-xenapi from the fence-agents-all Requires list so it is no longer pulled in by the metapackage. The subpackage is still built but not installed by default.
Verified: build succeeds and fence-agents-all no longer requires fence-agents-xenapi.
Part of fixing: workitem