Skip to content

feat(fence-agents): remove fence-agents-xenapi from metapackage#16464

Merged
reubeno merged 1 commit intotomls/base/mainfrom
chrco/remove-xen-fence-agents
Apr 6, 2026
Merged

feat(fence-agents): remove fence-agents-xenapi from metapackage#16464
reubeno merged 1 commit intotomls/base/mainfrom
chrco/remove-xen-fence-agents

Conversation

@christopherco
Copy link
Copy Markdown
Collaborator

Azure Linux targets Hyper-V/KVM, not Xen. Remove fence-agents-xenapi from the fence-agents-all Requires list so it is no longer pulled in by the metapackage. The subpackage is still built but not installed by default.

Verified: build succeeds and fence-agents-all no longer requires fence-agents-xenapi.

Part of fixing: workitem

Azure Linux targets Hyper-V/KVM, not Xen. Remove fence-agents-xenapi
from the fence-agents-all Requires list so it is no longer pulled in
by the metapackage. The subpackage is still built but not installed
by default.

Verified: build succeeds and fence-agents-all no longer requires
fence-agents-xenapi.
@christopherco christopherco marked this pull request as ready for review April 5, 2026 07:22
Copilot AI review requested due to automatic review settings April 5, 2026 07:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the Xen-specific fence-agents-xenapi dependency from the fence-agents-all metapackage so Azure Linux (Hyper-V/KVM-focused) no longer pulls it in by default, while still building the subpackage.

Changes:

  • Add a dedicated fence-agents.comp.toml with an overlay to remove fence-agents-xenapi from the metapackage Requires.
  • Remove the now-redundant bare fence-agents entry from components-full.toml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
base/comps/fence-agents/fence-agents.comp.toml Introduces an overlay intended to drop fence-agents-xenapi from the fence-agents-all Requires.
base/comps/components-full.toml Removes [components.fence-agents] because the component now has a dedicated *.comp.toml file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +5 to +10
# Clearing the package name leaves " \\" — a blank continuation that adds
# only harmless whitespace to the Requires list.
[[components.fence-agents.overlays]]
description = "Remove fence-agents-xenapi from fence-agents-all Requires - Xen not needed for Azure Linux"
type = "spec-search-replace"
regex = 'fence-agents-xenapi'
Copy link

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec-search-replace is currently unscoped and will replace every occurrence of fence-agents-xenapi in the spec. Repo guidance recommends scoping regex overlays with section and package to limit blast radius (see .github/instructions/comp-toml.instructions.md:119-120). Since this is intended to affect only the fence-agents-all subpackage Requires, please scope it accordingly and ensure the replacement also removes any adjacent separators/line-continuation so we don’t rely on a blank \ continuation remaining in the tag value.

Suggested change
# Clearing the package name leaves " \\" — a blank continuation that adds
# only harmless whitespace to the Requires list.
[[components.fence-agents.overlays]]
description = "Remove fence-agents-xenapi from fence-agents-all Requires - Xen not needed for Azure Linux"
type = "spec-search-replace"
regex = 'fence-agents-xenapi'
# Remove the entire dependency entry, including any trailing continuation,
# so the Requires value does not retain an empty "\\" line.
[[components.fence-agents.overlays]]
description = "Remove fence-agents-xenapi from fence-agents-all Requires - Xen not needed for Azure Linux"
type = "spec-search-replace"
section = "%package"
package = "all"
regex = '^[[:space:]]*fence-agents-xenapi([[:space:]][^\\]*)?([[:space:]]*\\)?[[:space:]]*$'

Copilot uses AI. Check for mistakes.
@reubeno reubeno merged commit 3e62d2a into tomls/base/main Apr 6, 2026
9 checks passed
@reubeno reubeno deleted the chrco/remove-xen-fence-agents branch April 6, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants