lint: fix no-changed-when and schema violations and enforce them

.ansible-lint

@@ -10,9 +10,8 @@ exclude_paths:
   # these are template results, so they do not need formatting:
   - partition/roles/sonic/test/data/**/metal.yaml
 
-# TODO: we need to gradually fix these!
+# role-name and var-naming are intentionally kept as warnings because renaming
+# roles or variables would break downstream consumers of these roles.
 warn_list:
   - role-name
-  - schema
   - var-naming
-  - no-changed-when

.yamllint

@@ -18,8 +18,8 @@ rules:
   braces:
     min-spaces-inside: 0 # yamllint defaults to 0
     max-spaces-inside: 1 # yamllint defaults to 0
-  # key-duplicates:
-  #   forbid-duplicated-merge-keys: true # not enabled by default
+  key-duplicates:
+    forbid-duplicated-merge-keys: true # not enabled by default
   octal-values:
     forbid-implicit-octal: true # yamllint defaults to false
     forbid-explicit-octal: true # yamllint defaults to false

common/roles/metal-deployment-token/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: metal-deployment-token
   author: metal-stack
   description: This role reads out an admin deployment token from the metal-apiserver and exports it in order to deploy infra services with it.
   license: MIT

common/roles/metal-v2-client/meta/main.yaml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: metal-v2-client
   author: metal-stack
   description: Installs the metal-stack v2 client library.
   license: MIT

control-plane/roles/auditing-timescaledb/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: auditing-timescaledb
   author: metal-stack
   description: Deploys a timescaledb database for auditing.
   license: MIT

control-plane/roles/gardener-cloud-profile/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: gardener-cloud-profile
   author: metal-stack
   description: Deploys Gardener cloud profile for a metal-stack installation.
   license: MIT

control-plane/roles/gardener-extensions/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: gardener-extensions
   author: metal-stack
   description: Deploys Gardener Extensions.
   license: MIT

control-plane/roles/gardener-gardenlet/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: gardener-gardenlet
   author: metal-stack
   description: Deploys Gardener gardenlet through the operator.
   license: MIT

control-plane/roles/gardener-logging/meta/main.yaml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: gardener-logging
   author: metal-stack
   description: Deploys Alloy into a Gardener seed.
   license: MIT

control-plane/roles/gardener-managed-seeds/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: gardener-managed-seeds
   author: metal-stack
   description: Deploys Gardener managed seeds.
   license: MIT

control-plane/roles/gardener-monitoring-certs/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: gardener-monitoring-certs
   author: metal-stack
   description: Deploys certificates used for monitoring components of the Gardener.
   license: MIT

control-plane/roles/gardener-operator/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: gardener-operator
   author: metal-stack
   description: Deploys the Gardener operator.
   license: MIT

control-plane/roles/gardener-partition-proxy/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: gardener-partition-proxy
   author: metal-stack
   description: Deploys an nginx into a Gardener shooted seed to expose partition services.
   license: MIT

control-plane/roles/gardener-projects/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: gardener-projects
   author: metal-stack
   description: Deploys Gardener projects.
   license: MIT

control-plane/roles/gardener-shoots/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: gardener-shoots
   author: metal-stack
   description: Deploys Gardener shoots.
   license: MIT

control-plane/roles/gardener-virtual-garden-access/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: gardener-virtual-garden-access
   author: metal-stack
   description: Deploys a managed resource for accessing the virtual garden.
   license: MIT

control-plane/roles/headscale/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: headscale
   author: metal-stack
   description: Deploys headscalee for the metal-stack firewall VPN.
   license: MIT

control-plane/roles/ipam-db/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: ipam-db
   author: metal-stack
   description: Deploys an ipam database for the go-ipam.
   license: MIT

control-plane/roles/isolated-clusters/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: isolated-clusters
   author: metal-stack
   description: Deploys additional services for the isolated cluster feature.
   license: MIT

control-plane/roles/logging-common/meta/main.yaml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: logging-common
   author: metal-stack
   description: Deploys logging components common to all environments
   license: MIT

control-plane/roles/logging/meta/main.yaml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: logging
   author: metal-stack
   description: Deploys a logging stack for the metal-stack control plane.
   license: MIT

control-plane/roles/masterdata-db/meta/main.yaml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: masterdata-db
   author: metal-stack
   description: Deploys a database for the masterdata-api.
   license: MIT

control-plane/roles/metal-db/meta/main.yaml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: metal-db
   author: metal-stack
   description: Deploys a database for the metal-api.
   license: MIT

control-plane/roles/metal-python/meta/main.yaml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: metal-python
   author: metal-stack
   description: Installs the metal-python client library.
   license: MIT

control-plane/roles/metal/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: metal
   author: metal-stack
   description: This role basically deploys the metal-control-plane.
   license: MIT

control-plane/roles/monitoring/meta/main.yaml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: monitoring
   author: metal-stack
   description: Deploys a monitoring stack for the metal-stack control plane.
   license: MIT

control-plane/roles/nsq/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: nsq
   author: metal-stack
   description: Deploys nsq in a standalone configuration.
   license: MIT

control-plane/roles/postgres-backup-restore/meta/main.yaml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: postgres-backup-restore
   author: metal-stack
   description: Deploys a postgres database including the backup-restore-sidecar container.
   license: MIT

control-plane/roles/prepare/meta/main.yaml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: prepare
   author: metal-stack
   description: Preparation tasks for the deployment of the metal-control-plane.
   license: MIT

control-plane/roles/rethinkdb-backup-restore/meta/main.yaml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: rethinkdb-backup-restore
   author: metal-stack
   description: Deploys a rethinkdb database including the backup-restore-sidecar container.
   license: MIT

control-plane/roles/valkey/meta/main.yaml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: valkey
   author: metal-stack
   description: Deploys valkey into the control plane.
   license: MIT

control-plane/roles/zitadel-db/meta/main.yaml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: zitadel-db
   author: metal-stack
   description: Deploys a database for the zitadel oidc provider.
   license: MIT

control-plane/roles/zitadel/meta/main.yaml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: zitadel
   author: metal-stack
   description: Deploys zitadel into the control plane.
   license: MIT

meta/main.yml

@@ -1,9 +1,9 @@
 ---
 galaxy_info:
   author: metal-stack
-  company:
+  description: Ansible roles for deploying and operating metal-stack.
   license: "license (MIT)"
-  min_ansible_version: 2.9
+  min_ansible_version: "2.9"
   platforms:
     - name: Ubuntu
       versions:

partition/roles/alloy/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: alloy
   author: metal-stack
   description: Deploys alloy.
   license: MIT

partition/roles/dhcp-relay/tasks/main.yaml

@@ -10,17 +10,21 @@
 
 - name: Add dhcp relay interface
   ansible.builtin.command: net add dhcp relay interface {{ dhcp_relay_interface }}
+  changed_when: true
 
 - name: Remove priorly configured dhcp relay servers
   ansible.builtin.command: net del dhcp relay server
+  changed_when: true
 
 - name: Listify dhcp relays servers
   ansible.builtin.set_fact:
     _dhcp_relay_servers: "{{ [dhcp_relay_server] if dhcp_relay_server is string else dhcp_relay_server }}"
 
 - name: Add dhcp relay server
   ansible.builtin.command: net add dhcp relay server {{ item }}
+  changed_when: true
   loop: "{{ _dhcp_relay_servers }}"
 
 - name: Commit configuration
   ansible.builtin.command: net commit
+  changed_when: true

partition/roles/dhcp/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: dhcp
   author: metal-stack
   description: Configures and starts dhcpd.
   license: MIT

partition/roles/frr/handlers/main.yaml

@@ -11,3 +11,4 @@
 
 - name: Reload sysctls
   ansible.builtin.command: sysctl --system
+  changed_when: true

partition/roles/image-cache/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: image-cache
   author: metal-stack
   description: Deploys an image cache to a partition.
   license: MIT

partition/roles/metal-bmc/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: metal-bmc
   author: metal-stack
   description: Deploys the metal-bmc.
   license: MIT

partition/roles/metal-core/meta/main.yml

@@ -1,6 +1,5 @@
 ---
 galaxy_info:
-  role_name: metal-core
   author: metal-stack
   description: Deploys the metal-core.
   license: MIT
@@ -9,8 +8,8 @@ galaxy_info:
   platforms:
     - name: Cumulus
       versions:
-        - 3
-    - name: SONiC
+        - "3.0"
+    - name: Debian
       versions:
         - all