lint: fix no-changed-when and schema violations and enforce them - #708
Open
GeertJohan wants to merge 1 commit into
Open
lint: fix no-changed-when and schema violations and enforce them#708GeertJohan wants to merge 1 commit into
GeertJohan wants to merge 1 commit into
Conversation
- add changed_when to all command/shell/raw tasks flagged by no-changed-when, using changed_when: false for read-only commands and changed_when: true for commands that always apply changes - fix schema[meta] violations: drop the optional role_name field from galaxy_info (it is not used when roles are imported via their directory paths), add a missing description to the top-level meta/main.yml and replace invalid platform entries (SONiC is not a valid galaxy platform) - add a missing meta/main.yml to the gnmic role so that the setup_yaml action from ansible-common can be resolved (fixes syntax-check[unknown-module]) - remove no-changed-when and schema from the ansible-lint warn_list so they are enforced from now on; role-name and var-naming stay warnings because renaming roles or variables would break downstream consumers - enable forbid-duplicated-merge-keys in .yamllint (no violations)
Contributor
|
Review missing from @metal-stack/metal-roles-maintainers-isolated-clusters and @metal-stack/metal-roles-maintainers-partition |
vknabel
approved these changes
Aug 18, 2026
mwennrich
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used AI-Tools ✨
Claude Fable 5