Skip to content

fix: make e2e scoping on-by-default so fork PRs benefit #7709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashishjain0512 merged 2 commits into from
May 5, 2026
+10 −6
Merged

fix: make e2e scoping on-by-default so fork PRs benefit #7709

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e57282e
fix: make e2e scoping on-by-default so fork PRs benefit
ashishjain0512 May 5, 2026
dc52afc
Merge branch 'develop' into chore/e2e-scope-skip-ignorable-files
ashishjain0512 May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,13 @@ jobs:
FULL_MATRIX='[1,2,3,4,5]'
SCOPED_MATRIX='[1]'

# Feature flag off → always use full matrix
if [ "${E2E_SCOPE_BY_DIAGRAM}" != "true" ]; then
# Kill-switch: set the repo variable E2E_SCOPE_BY_DIAGRAM to 'false'
# to disable scoping. Scoping is ON by default so that fork PRs
# (where repository variables are unavailable) still benefit from it.
if [ "${E2E_SCOPE_BY_DIAGRAM}" = "false" ]; then
echo "spec_pattern=" >> "$GITHUB_OUTPUT"
echo "matrix=${FULL_MATRIX}" >> "$GITHUB_OUTPUT"
echo "[detect-scope] Feature flag disabled — full suite."
echo "[detect-scope] Scoping disabled via kill-switch — full suite."
exit 0
fi

Expand Down Expand Up @@ -160,9 +162,11 @@ jobs:
echo "[detect-scope] Cannot scope — full suite."
fi
env:
# Toggle diagram-scoped e2e: set this repository variable to 'true'
# (GitHub → Settings → Secrets and variables → Actions → Variables)
E2E_SCOPE_BY_DIAGRAM: "${{ vars.E2E_SCOPE_BY_DIAGRAM == 'true' }}"
# Scoping is ON by default. To disable, set this repository variable
# to 'false' (GitHub → Settings → Secrets and variables → Actions → Variables).
# Using == 'false' (instead of == 'true') ensures fork PRs — where
# repository variables are not exposed — still get scoped runs.
E2E_SCOPE_BY_DIAGRAM: "${{ vars.E2E_SCOPE_BY_DIAGRAM == 'false' && 'false' || 'true' }}"

e2e:
# Skip the entire e2e job when only docs/ignorable files changed.
Expand Down
Loading