Skip to content

fix: make e2e scoping on-by-default so fork PRs benefit#7709

Merged
ashishjain0512 merged 2 commits into
developfrom
chore/e2e-scope-skip-ignorable-files
May 5, 2026
Merged

fix: make e2e scoping on-by-default so fork PRs benefit#7709
ashishjain0512 merged 2 commits into
developfrom
chore/e2e-scope-skip-ignorable-files

Conversation

@ashishjain0512
Copy link
Copy Markdown
Collaborator

Summary

Fixes e2e scoping for fork PRs (all external contributor PRs).

GitHub does not expose repository variables (vars.*) to workflows triggered by pull requests from forks. The previous logic required E2E_SCOPE_BY_DIAGRAM == 'true' to enable scoping, which meant every fork PR saw the variable as empty and fell back to the full 5-container suite — defeating the purpose of the scoping optimization from #7619 and #7704.

Change

Flip the flag logic: scoping is now ON by default. The repository variable acts as a kill-switch — set it to 'false' to disable scoping. When the variable is unavailable (fork PRs), the expression evaluates to 'true', preserving scoped runs.

Scenario vars.E2E_SCOPE_BY_DIAGRAM Scoping active?
Fork PR unavailable ✅ Yes (default)
Same-repo PR 'true' (or unset) ✅ Yes
Kill-switch engaged 'false' ❌ No (full suite)

Files changed

  • .github/workflows/e2e.yml — Flip the flag check from opt-in (!= 'true') to opt-out (= 'false')

GitHub does not expose repository variables (vars.*) to workflows
triggered by pull requests from forks. The previous logic required
E2E_SCOPE_BY_DIAGRAM == 'true' to enable scoping, which meant every
fork PR fell back to the full 5-container suite.

Flip the logic: scoping is now ON by default. The repository variable
acts as a kill-switch — set it to 'false' to disable scoping. When
the variable is unavailable (fork PRs) the expression evaluates to
'true', preserving scoped runs for external contributors.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 5, 2026

⚠️ No Changeset found

Latest commit: dc52afc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link
Copy Markdown

netlify Bot commented May 5, 2026

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit dc52afc
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/69f9afac7427660008022830
😎 Deploy Preview https://deploy-preview-7709--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the Type: Other Not an enhancement or a bug label May 5, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 5, 2026

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/@mermaid-js/examples@7709

mermaid

npm i https://pkg.pr.new/mermaid@7709

@mermaid-js/layout-elk

npm i https://pkg.pr.new/@mermaid-js/layout-elk@7709

@mermaid-js/layout-tidy-tree

npm i https://pkg.pr.new/@mermaid-js/layout-tidy-tree@7709

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/@mermaid-js/mermaid-zenuml@7709

@mermaid-js/parser

npm i https://pkg.pr.new/@mermaid-js/parser@7709

@mermaid-js/tiny

npm i https://pkg.pr.new/@mermaid-js/tiny@7709

commit: dc52afc

@ashishjain0512 ashishjain0512 marked this pull request as ready for review May 5, 2026 08:51
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.31%. Comparing base (36ef39e) to head (dc52afc).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #7709   +/-   ##
=======================================
  Coverage     3.31%   3.31%           
=======================================
  Files          542     542           
  Lines        57206   57206           
  Branches       840     840           
=======================================
  Hits          1898    1898           
  Misses       55308   55308           
Flag Coverage Δ
unit 3.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@argos-ci
Copy link
Copy Markdown

argos-ci Bot commented May 5, 2026

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 changed May 5, 2026, 9:16 AM

@ashishjain0512 ashishjain0512 merged commit 71f9731 into develop May 5, 2026
27 checks passed
@ashishjain0512 ashishjain0512 deleted the chore/e2e-scope-skip-ignorable-files branch May 5, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Other Not an enhancement or a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant