fix: make e2e scoping on-by-default so fork PRs benefit#7709
Conversation
GitHub does not expose repository variables (vars.*) to workflows triggered by pull requests from forks. The previous logic required E2E_SCOPE_BY_DIAGRAM == 'true' to enable scoping, which meant every fork PR fell back to the full 5-container suite. Flip the logic: scoping is now ON by default. The repository variable acts as a kill-switch — set it to 'false' to disable scoping. When the variable is unavailable (fork PRs) the expression evaluates to 'true', preserving scoped runs for external contributors.
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7709 +/- ##
=======================================
Coverage 3.31% 3.31%
=======================================
Files 542 542
Lines 57206 57206
Branches 840 840
=======================================
Hits 1898 1898
Misses 55308 55308
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Summary
Fixes e2e scoping for fork PRs (all external contributor PRs).
GitHub does not expose repository variables (
vars.*) to workflows triggered by pull requests from forks. The previous logic requiredE2E_SCOPE_BY_DIAGRAM == 'true'to enable scoping, which meant every fork PR saw the variable as empty and fell back to the full 5-container suite — defeating the purpose of the scoping optimization from #7619 and #7704.Change
Flip the flag logic: scoping is now ON by default. The repository variable acts as a kill-switch — set it to
'false'to disable scoping. When the variable is unavailable (fork PRs), the expression evaluates to'true', preserving scoped runs.vars.E2E_SCOPE_BY_DIAGRAM'true'(or unset)'false'Files changed
.github/workflows/e2e.yml— Flip the flag check from opt-in (!= 'true') to opt-out (= 'false')