Skip to content

fix: Actually start the ServiceDateRollover worker #3248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshlarson merged 3 commits into from
Jun 11, 2026
+4 −2
Merged

fix: Actually start the ServiceDateRollover worker #3248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48aaf42
fix: Actually start the `ServiceDateRollover` worker
joshlarson Jun 11, 2026
2525214
fix: Don't start it in test
joshlarson Jun 11, 2026
1a2e17c
!fixup wait a little longer to receive the event
thecristen Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/dotcom/application.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ defmodule Dotcom.Application do
] ++
if Application.get_env(:dotcom, :env) != :test do
[
Dotcom.ServiceDateRollover,
Dotcom.ViaFairmount,
{Dotcom.SystemStatus.CommuterRailCache, []},
{Dotcom.SystemStatus.SubwayCache, []}
Expand Down
1 change: 1 addition & 0 deletions lib/dotcom/service_date_rollover.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ defmodule Dotcom.ServiceDateRollover do
end_of_service_day()
|> DateTime.shift(microsecond: {1, 4})
|> DateTime.diff(@date_time_module.now(), :millisecond)
|> max(1000)
end

def subscribe() do
Expand Down
4 changes: 2 additions & 2 deletions test/dotcom/service_date_rollover_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,14 @@ defmodule Dotcom.ServiceDateRolloverTest do
:ok = Phoenix.PubSub.subscribe(Dotcom.PubSub, topic_name())
{:ok, _pid} = start_supervised({Dotcom.ServiceDateRollover, []}, id: :service_date_rollover)

assert_receive {:service_date_rollover, _date}, 200
assert_receive {:service_date_rollover, _date}, 1200
end

test "subscribe/0 subscribes to the service date rollover topic" do
:ok = Dotcom.ServiceDateRollover.subscribe()
{:ok, _pid} = start_supervised({Dotcom.ServiceDateRollover, []}, id: :service_date_rollover)

assert_receive {:service_date_rollover, _date}, 200
assert_receive {:service_date_rollover, _date}, 1200
end
end
end
Loading