fix: Actually start the ServiceDateRollover worker#3248
Merged
Conversation
thecristen
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
No ticket - just realized that there actually was a way to test this.... and then realized that it wasn't working!
Implementation
Two things:
Dotcom.ServiceDateRolloverto the supervision tree.Per point number 2, one of the times I was testing this out, I got 👇 error. Might as well avoid that!
Screenshots
Screen.Recording.2026-06-10.at.9.59.51.PM.mov
I was able to make
ServiceDateTimepretend that the service-rollover-time was 9:59PM, which meant that today's bus schedules didn't show up until after that time (since before the service-rollover-time, it pulls yesterday's schedules instead, which are all in the past). So before service-rollover-time, bus schedules will be absent, and the last trip will be labeledLast; after service-rollover-time, today's schedules will populate. ☝️ video shows the schedules spontaneously populating (at my customized service-rollover-time of 9:59).How to test
It actually is possible to mangle
ServiceDateTime'sservice_date/0andend_of_service_day/0functions to set your service day to whenever you want (I chose one minute in the future). Most of that module assumes that the service rollover time will be right on the hour, so there's some additional mangling you might need to do if you want to be able to test it more than once per hour.I rewrote the functions like so 👇
Notes
I have now achieved semantic satiation with the phrase "service rollover time". I hope you're happy.