fix(i18n): correct broken German translations - #9715
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe German locale updates correct English placeholders, misspelled German labels, and selected terminology in common and power-k translation files. ChangesGerman locale corrections
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to The PR corrects several German interface labels without changing application behavior or runtime configuration. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description provides a clear summary, lists the changed translation keys, explains the approach, records testing, and references issue Full details: Linked Issues checkExplanation The PR fixes the fabricated words, untranslated English strings, and duplicate command-palette label identified in issue [ Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| "pin": "Anheften", | ||
| "unpin": "Lösen", | ||
| "workspace_dashboards": "Däschbords", | ||
| "pi_chat": "AI Tschät", |
There was a problem hiding this comment.
As this is the name of the product, we wanted to keep it as it is.
There was a problem hiding this comment.
Agreed - kept as "Plane AI" (the product name), matching the English source. Thanks for reviewing.
Summary
Fixes #9643 — several German translations were either not German at all (English words left untranslated) or contained fabricated words that do not exist in the German language.
Changes
packages/i18n/src/locales/de/common.jsoncommon.completed_on:Completed on→Abgeschlossen amcommon.your_profile:Your profile→Ihr Profilcommon.developer:Developer→Entwicklercommon.work_structure:Work structure→Arbeitsstrukturcommon.execution:Execution→Ausführungcommon.administration:Administration→Verwaltungworkspace_dashboards:Däschbords→Dashboards(fabricated word)pi_chat:AI Tschät→Plane AI(fabricated word)packages/i18n/src/locales/de/power-k.jsongroup_titles.preferences:Einstellungen→Präferenzen(was identical tosettings, making two different command-palette groups indistinguishable)Why this approach
These are the verifiable cases from the issue: words that do not exist in German (the two fabricated words), English strings left untranslated, and the same German word used for two different items. Other German strings matching English (e.g.
GitHub,OK,ID, placeholders like123456) are proper nouns or technical terms and were intentionally left unchanged.Testing
tsx scripts/sync-check.ts(i18n quality gate) — all locales in sync with English, no issuesoxfmt --checkinpackages/i18n— all files formattedNotes
Summary by CodeRabbit