Skip to content

commit_timeline: perform async GPU copies as soon as possible #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mahkoh merged 3 commits into from
Oct 27, 2026
Merged

commit_timeline: perform async GPU copies as soon as possible #1311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ebdf51
commit_timeline: don't use WlSurfaceError
mahkoh Oct 27, 2026
0375aec
commit_timeline: add commit error helper
mahkoh Oct 27, 2026
318ac59
commit_timeline: perform async GPU copies as soon as possible
mahkoh Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions src/ifs/wl_surface.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ use crate::gfx_api::AsyncShmGfxTexture;
use crate::gfx_api::BufferResv;
use crate::gfx_api::BufferResvUser;
use crate::gfx_api::FdSync;
use crate::gfx_api::GfxError;
use crate::gfx_api::GfxStagingBuffer;
use crate::gfx_api::ReleaseSync;
use crate::gfx_api::SampleRect;
Expand Down Expand Up @@ -75,7 +74,6 @@ use crate::ifs::wl_surface::commit_timeline::CommitTimelineError;
use crate::ifs::wl_surface::cursor::CursorSurface;
use crate::ifs::wl_surface::dnd_icon::DndIcon;
use crate::ifs::wl_surface::jay_sync_file_release::SyncFileRelease;
use crate::ifs::wl_surface::prime::PrimeError;
use crate::ifs::wl_surface::prime::PrimeSurfaceBuffer;
use crate::ifs::wl_surface::prime::SurfacePrimeState;
use crate::ifs::wl_surface::tray::TrayItemId;
Expand All @@ -99,7 +97,6 @@ use crate::ifs::wl_surface::zwlr_layer_surface_v1::ZwlrLayerSurfaceV1Error;
use crate::ifs::wp_content_type_v1::ContentType;
use crate::ifs::wp_presentation_feedback::PresentationFeedback;
use crate::ifs::zwp_linux_dmabuf_feedback_v1::ZwpLinuxDmabufFeedbackV1;
use crate::io_uring::IoUringError;
use crate::keyboard::KeyboardState;
use crate::leaks::Tracker;
use crate::object::BreakLoops;
Expand Down Expand Up @@ -162,7 +159,6 @@ use crate::utils::obj_and_id::ObjAndId;
use crate::utils::obj_and_id::ObjWithId;
use crate::utils::reset::Reset;
use crate::utils::smallmap::SmallMap;
use crate::video::dmabuf::ChainedCopyError;
use crate::video::dmabuf::DMA_BUF_SYNC_READ;
use crate::video::drm::syncobj::Syncobj;
use crate::video::drm::syncobj::SyncobjPoint;
Expand Down Expand Up @@ -2532,22 +2528,10 @@ pub enum WlSurfaceError {
UnexpectedSyncPoints,
#[error("The supplied region is invalid")]
InvalidRect,
#[error("There is no render context")]
NoRenderContext,
#[error("Could not create a shm texture")]
CreateAsyncShmTexture(#[source] GfxError),
#[error("Could not prepare upload to a shm texture")]
PrepareAsyncUpload(#[source] GfxError),
#[error("Could not register a commit timeout")]
RegisterCommitTimeout(#[source] IoUringError),
#[error("Content update contains release callbacks but no non-null buffer")]
SurfaceReleaseWithoutAttach,
#[error("Content update contains sync file release but no non-null buffer")]
SyncFileReleaseWithoutAttach,
#[error("Could not prepare prime copy")]
PreparePrimeCopy(#[source] PrimeError),
#[error("Could not perform prime copy")]
PrimeCopy(#[source] ChainedCopyError),
#[error("The surface already has an extension object")]
HasExt,
}
Expand Down
Loading
Loading