Repository navigation
commit_timeline: perform async GPU copies as soon as possible - #1311
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔵 Needs a closer look
Earlier GPU access changes buffer lifetimes and cross-timeline ordering, requiring human validation of asynchronous interactions.
No open issues 🎉
What changed in this PR
This PR starts asynchronous GPU buffer transfers earlier in the surface commit pipeline, while retaining ordering through a dedicated buffer queue.
Changes:
- Schedule shared-memory uploads and cross-device copies when buffer-access dependencies are satisfied.
- Track buffer ordering across commits and timeline waits.
- Move transfer and timeout errors into
CommitTimelineError.
| File | Description |
|---|---|
src/ifs/wl_surface/commit_timeline.rs |
Adds early transfer scheduling, buffer-queue tracking, and timeline-owned error handling. |
src/ifs/wl_surface.rs |
Removes error variants and imports moved to the commit timeline. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.